Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: chrome/browser/ui/views/status_bubble_views.cc

Issue 6881107: Rework the way Widget::Init works: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/status_bubble_views.cc
===================================================================
--- chrome/browser/ui/views/status_bubble_views.cc (revision 83020)
+++ chrome/browser/ui/views/status_bubble_views.cc (working copy)
@@ -559,18 +559,19 @@
void StatusBubbleViews::Init() {
if (!popup_.get()) {
- Widget::CreateParams params(Widget::CreateParams::TYPE_POPUP);
- params.transparent = true;
- params.accept_events = false;
- params.delete_on_destroy = false;
- popup_.reset(Widget::CreateWidget(params));
+ popup_.reset(Widget::CreateWidget());
views::Widget* frame = base_view_->GetWidget();
if (!view_)
view_ = new StatusView(this, popup_.get(), frame->GetThemeProvider());
if (!expand_view_.get())
expand_view_.reset(new StatusViewExpander(this, view_));
popup_->SetOpacity(0x00);
- popup_->Init(frame->GetNativeView(), gfx::Rect());
+ Widget::CreateParams params(Widget::CreateParams::TYPE_POPUP);
+ params.transparent = true;
+ params.accept_events = false;
+ params.delete_on_destroy = false;
+ params.parent = frame->GetNativeView();
+ popup_->Init(params);
popup_->SetContentsView(view_);
Reposition();
popup_->Show();

Powered by Google App Engine
This is Rietveld 408576698