Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: chrome/browser/chromeos/login/helper.cc

Issue 6881107: Rework the way Widget::Init works: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/background_view.cc ('k') | chrome/browser/chromeos/login/message_bubble.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/helper.cc
===================================================================
--- chrome/browser/chromeos/login/helper.cc (revision 83020)
+++ chrome/browser/chromeos/login/helper.cc (working copy)
@@ -109,13 +109,16 @@
throbber->set_stop_delay_ms(0);
gfx::Rect throbber_bounds = CalculateThrobberBounds(throbber);
+ throbber_widget_ = views::Widget::CreateWidget();
+ static_cast<views::WidgetGtk*>(throbber_widget_->native_widget())->
+ make_transient_to_parent();
+
+ throbber_bounds.Offset(host_view_->GetScreenBounds().origin());
views::Widget::CreateParams params(views::Widget::CreateParams::TYPE_WINDOW);
params.transparent = true;
- throbber_widget_ = views::Widget::CreateWidget(params);
- static_cast<views::WidgetGtk*>(throbber_widget_)->make_transient_to_parent();
-
- throbber_bounds.Offset(host_view_->GetScreenBounds().origin());
- throbber_widget_->Init(host_gtk_window, throbber_bounds);
+ params.bounds = throbber_bounds;
+ params.parent = host_gtk_window;
+ throbber_widget_->Init(params);
throbber_widget_->SetContentsView(throbber);
// This keeps the window from flashing at startup.
gdk_window_set_back_pixmap(
« no previous file with comments | « chrome/browser/chromeos/login/background_view.cc ('k') | chrome/browser/chromeos/login/message_bubble.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698