Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1408)

Unified Diff: chrome/browser/ui/views/theme_install_bubble_view.cc

Issue 6881107: Rework the way Widget::Init works: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_strip.cc ('k') | views/controls/menu/menu_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/theme_install_bubble_view.cc
===================================================================
--- chrome/browser/ui/views/theme_install_bubble_view.cc (revision 83020)
+++ chrome/browser/ui/views/theme_install_bubble_view.cc (working copy)
@@ -70,13 +70,13 @@
NotificationType::EXTENSION_WILL_SHOW_CONFIRM_DIALOG,
NotificationService::AllSources());
- gfx::Rect rc(0, 0, 0, 0);
+ popup_ = views::Widget::CreateWidget();
+ popup_->SetOpacity(0xCC);
views::Widget::CreateParams params(views::Widget::CreateParams::TYPE_POPUP);
params.transparent = true;
params.accept_events = false;
- popup_ = views::Widget::CreateWidget(params);
- popup_->SetOpacity(0xCC);
- popup_->Init(tab_contents->GetNativeView(), rc);
+ params.parent = tab_contents->GetNativeView();
+ popup_->Init(params);
popup_->SetContentsView(this);
Reposition();
popup_->Show();
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_strip.cc ('k') | views/controls/menu/menu_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698