Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed)

Created:
6 years, 2 months ago by eustas
Modified:
6 years, 2 months ago
Reviewers:
vsevik, apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: remove "type" getters in Resource and NetworkRequest. Motivation: 1) Getters are evil 2) "type" is too generic 3) "contentType" method returns exactly the same value. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184218

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : update tests #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -81 lines) Patch
M LayoutTests/http/tests/inspector/network-preflight-options.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/async-xhr-json-mime-type.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/network-iframe-load-and-delete.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/network/network-image-404.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/network-xhr-async.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/network-xhr-async-response-type-blob.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/network-xhr-binary-content.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/network-xhr-same-url-as-main-resource.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/network/network-xhr-sync.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-mimetype.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-test.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/websocket/websocket-frame.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/websocket/websocket-frame-error.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/network/network-filter-updated-requests.html View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/audits/AuditLauncherView.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/audits/AuditRules.js View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/bindings/NetworkUISourceCodeProvider.js View 1 2 chunks +4 lines, -3 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/network/NetworkItemView.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 1 5 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/network/RequestPreviewView.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/network/RequestResponseView.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/network/RequestView.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/resources/ResourcesPanel.js View 1 2 3 6 chunks +16 lines, -9 lines 0 comments Download
M Source/devtools/front_end/sdk/NetworkManager.js View 1 5 chunks +11 lines, -10 lines 0 comments Download
M Source/devtools/front_end/sdk/NetworkRequest.js View 1 4 chunks +11 lines, -7 lines 0 comments Download
M Source/devtools/front_end/sdk/Resource.js View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/ResourceTreeModel.js View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
eustas
6 years, 2 months ago (2014-10-20 16:37:49 UTC) #2
eustas
On 2014/10/20 16:37:49, eustas wrote: Ping
6 years, 2 months ago (2014-10-21 11:11:32 UTC) #3
eustas
PTAL
6 years, 2 months ago (2014-10-22 07:29:20 UTC) #4
apavlov
lgtm https://codereview.chromium.org/667743002/diff/20001/Source/devtools/front_end/resources/ResourcesPanel.js File Source/devtools/front_end/resources/ResourcesPanel.js (right): https://codereview.chromium.org/667743002/diff/20001/Source/devtools/front_end/resources/ResourcesPanel.js#newcode1277 Source/devtools/front_end/resources/ResourcesPanel.js:1277: this._setBubbleText((this._resource.warnings + this._resource.errors) + ""); String(this._resource.warnings + this._resource.errors) ...
6 years, 2 months ago (2014-10-22 07:40:05 UTC) #5
eustas
https://codereview.chromium.org/667743002/diff/20001/Source/devtools/front_end/resources/ResourcesPanel.js File Source/devtools/front_end/resources/ResourcesPanel.js (right): https://codereview.chromium.org/667743002/diff/20001/Source/devtools/front_end/resources/ResourcesPanel.js#newcode1277 Source/devtools/front_end/resources/ResourcesPanel.js:1277: this._setBubbleText((this._resource.warnings + this._resource.errors) + ""); On 2014/10/22 07:40:05, apavlov ...
6 years, 2 months ago (2014-10-22 08:23:00 UTC) #6
vsevik
lgtm
6 years, 2 months ago (2014-10-22 14:15:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667743002/60001
6 years, 2 months ago (2014-10-22 14:38:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33102)
6 years, 2 months ago (2014-10-22 17:41:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667743002/60001
6 years, 2 months ago (2014-10-22 19:55:29 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 20:43:54 UTC) #14
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 184218

Powered by Google App Engine
This is Rietveld 408576698