Source/devtools/front_end/audits/AuditLauncherView.js - Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/audits/AuditLauncherView.js

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/network/network-filter-updated-requests.html ('k') | Source/devtools/front_end/audits/AuditRules.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/audits/AuditLauncherView.js

diff --git a/Source/devtools/front_end/audits/AuditLauncherView.js b/Source/devtools/front_end/audits/AuditLauncherView.js

index b418eba4b9c181cba3883e1647fad60937498d69..f237762e3d8a49fba6a8984c436f390c8358318a 100644

--- a/Source/devtools/front_end/audits/AuditLauncherView.js

+++ b/Source/devtools/front_end/audits/AuditLauncherView.js

@@ -81,7 +81,7 @@ WebInspector.AuditLauncherView.prototype = {

{

var request = /** @type {!WebInspector.NetworkRequest} */ (event.data);

// Ignore long-living WebSockets for the sake of progress indicator, as we won't be waiting them anyway.

- if (request.type === WebInspector.resourceTypes.WebSocket)

+ if (request.resourceType() === WebInspector.resourceTypes.WebSocket)

return;

++this._totalResources;

this._updateResourceProgress();

@@ -91,7 +91,7 @@ WebInspector.AuditLauncherView.prototype = {

{

var request = /** @type {!WebInspector.NetworkRequest} */ (event.data);

// See resorceStarted for details.

- if (request.type === WebInspector.resourceTypes.WebSocket)

+ if (request.resourceType() === WebInspector.resourceTypes.WebSocket)

return;

++this._loadedResources;

this._updateResourceProgress();