Source/devtools/front_end/console/ConsoleView.js - Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/console/ConsoleView.js

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/bindings/NetworkUISourceCodeProvider.js ('k') | Source/devtools/front_end/elements/ElementsPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/console/ConsoleView.js

diff --git a/Source/devtools/front_end/console/ConsoleView.js b/Source/devtools/front_end/console/ConsoleView.js

index 5b5ec4a26cd74c56de7ee4a993eb8f5a5231fd3c..06954a6cb26f1903bbe80c63c08a085388eb2474 100644

--- a/Source/devtools/front_end/console/ConsoleView.js

+++ b/Source/devtools/front_end/console/ConsoleView.js

@@ -657,7 +657,7 @@ WebInspector.ConsoleView.prototype = {

contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Clear console" : "Clear Console"), this._requestClearMessages.bind(this));

var request = consoleMessage ? consoleMessage.request : null;

- if (request && request.type === WebInspector.resourceTypes.XHR) {

+ if (request && request.resourceType() === WebInspector.resourceTypes.XHR) {

contextMenu.appendSeparator();

contextMenu.appendItem(WebInspector.UIString("Replay XHR"), NetworkAgent.replayXHR.bind(null, request.requestId));

}