Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1994)

Unified Diff: Source/devtools/front_end/network/RequestView.js

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/network/RequestView.js
diff --git a/Source/devtools/front_end/network/RequestView.js b/Source/devtools/front_end/network/RequestView.js
index 5602189866bb4bef761c3f59308e2cc9a376fb39..e9ceaa4fa200bcbc272001ea5d8e86f01a92aa5f 100644
--- a/Source/devtools/front_end/network/RequestView.js
+++ b/Source/devtools/front_end/network/RequestView.js
@@ -51,9 +51,9 @@ WebInspector.RequestView.prototype = {
*/
WebInspector.RequestView.hasTextContent = function(request)
{
- if (request.type.isTextType())
+ if (request.resourceType().isTextType())
return true;
- if (request.type === WebInspector.resourceTypes.Other || request.hasErrorStatusCode())
+ if (request.resourceType() === WebInspector.resourceTypes.Other || request.hasErrorStatusCode())
return !!request.content && !request.contentEncoded;
return false;
}
@@ -64,7 +64,7 @@ WebInspector.RequestView.hasTextContent = function(request)
*/
WebInspector.RequestView.nonSourceViewForRequest = function(request)
{
- switch (request.type) {
+ switch (request.resourceType()) {
case WebInspector.resourceTypes.Image:
return new WebInspector.ImageView(request.url, request.mimeType, request);
case WebInspector.resourceTypes.Font:
« no previous file with comments | « Source/devtools/front_end/network/RequestResponseView.js ('k') | Source/devtools/front_end/resources/ResourcesPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698