LayoutTests/http/tests/inspector/network/network-xhr-sync.html - Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/inspector/network/network-xhr-sync.html

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector/network/network-xhr-same-url-as-main-resource.html ('k') | LayoutTests/http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../inspector-test.js"></script>	3 <script src="../inspector-test.js"></script>

4 <script src="../network-test.js"></script>	4 <script src="../network-test.js"></script>

5 <script>	5 <script>

6 function test()	6 function test()

7 {	7 {

8 // Since this test could be run together with other inspector backend cache	8 // Since this test could be run together with other inspector backend cache

9 // tests, we need to reset size limits to default ones.	9 // tests, we need to reset size limits to default ones.

10 InspectorTest.resetInspectorResourcesData(step1);	10 InspectorTest.resetInspectorResourcesData(step1);

11	11

12 function step1()	12 function step1()

13 {	13 {

14 InspectorTest.recordNetwork();	14 InspectorTest.recordNetwork();

15 InspectorTest.makeSimpleXHR("GET", "resources/resource.php", false, step 2);	15 InspectorTest.makeSimpleXHR("GET", "resources/resource.php", false, step 2);

16 }	16 }

17	17

18 function step2()	18 function step2()

19 {	19 {

20 var request1 = InspectorTest.networkRequests().pop();	20 var request1 = InspectorTest.networkRequests().pop();

21 InspectorTest.addResult(request1.url);	21 InspectorTest.addResult(request1.url);

22 InspectorTest.addResult("resource.type: " + request1.type);	22 InspectorTest.addResult("resource.type: " + request1.resourceType());

23 InspectorTest.addResult("resource.content before requesting content: " + request1.content);	23 InspectorTest.addResult("resource.content before requesting content: " + request1.content);

24 InspectorTest.assertTrue(!request1.failed, "Resource loading failed.");	24 InspectorTest.assertTrue(!request1.failed, "Resource loading failed.");

25 request1.requestContent(step3);	25 request1.requestContent(step3);

26 }	26 }

27	27

28 function step3()	28 function step3()

29 {	29 {

30 var request1 = InspectorTest.networkRequests().pop();	30 var request1 = InspectorTest.networkRequests().pop();

31 InspectorTest.addResult("resource.content after requesting content: " + request1.content);	31 InspectorTest.addResult("resource.content after requesting content: " + request1.content);

32	32

33 InspectorTest.completeTest();	33 InspectorTest.completeTest();

34 }	34 }

35 }	35 }

36 </script>	36 </script>

37 </head>	37 </head>

38 <body onload="runTest()">	38 <body onload="runTest()">

39 <p>	39 <p>

40 Tests XHR network resource type and content for synchronous requests.	40 Tests XHR network resource type and content for synchronous requests.

41 <a href="https://bugs.webkit.org/show_bug.cgi?id=61205">Bug 61205</a>	41 <a href="https://bugs.webkit.org/show_bug.cgi?id=61205">Bug 61205</a>

42 </p>	42 </p>

43 </body>	43 </body>

44 </html>	44 </html>

OLD	NEW