LayoutTests/inspector/network/network-filter-updated-requests.html - Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest.

Unified Diff: LayoutTests/inspector/network/network-filter-updated-requests.html

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector/websocket/websocket-frame-error.html ('k') | Source/devtools/front_end/audits/AuditLauncherView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/network/network-filter-updated-requests.html

diff --git a/LayoutTests/inspector/network/network-filter-updated-requests.html b/LayoutTests/inspector/network/network-filter-updated-requests.html

index bbdeffd0e561b5dde9599e27c286214be5b08895..06a3d91c47bf25285200e4f32429f98d38cf19a3 100644

--- a/LayoutTests/inspector/network/network-filter-updated-requests.html

+++ b/LayoutTests/inspector/network/network-filter-updated-requests.html

@@ -11,11 +11,11 @@ function test() {

InspectorTest.addResult("Clicked '" + types.XHR.name() + "' button.");

var requestFoo = new WebInspector.NetworkRequest(WebInspector.targetManager.mainTarget(), "", "", "", "", "");

- requestFoo.type = types.Script;

+ requestFoo.setResourceType(types.Script);

requestFoo.requestId = "foo";

target._appendRequest(requestFoo);

var requestBar = new WebInspector.NetworkRequest(WebInspector.targetManager.mainTarget(), "", "", "", "", "");

- requestBar.type = types.Script;

+ requestBar.setResourceType(types.Script);

requestBar.requestId = "bar";

target._appendRequest(requestBar);

target.refresh();

@@ -25,11 +25,11 @@ function test() {

}

InspectorTest.addResult("");

- InspectorTest.addResult("Request [" + requestFoo.requestId + "] of type '" + requestFoo.type.name() + "' is hidden: " + isFilteredOut(requestFoo));

- InspectorTest.addResult("Request [" + requestBar.requestId + "] of type '" + requestBar.type.name() + "' is hidden: " + isFilteredOut(requestBar));

+ InspectorTest.addResult("Request [" + requestFoo.requestId + "] of type '" + requestFoo.resourceType().name() + "' is hidden: " + isFilteredOut(requestFoo));

+ InspectorTest.addResult("Request [" + requestBar.requestId + "] of type '" + requestBar.resourceType().name() + "' is hidden: " + isFilteredOut(requestBar));

InspectorTest.addResult("");

- requestFoo.type = types.XHR;

+ requestFoo.setResourceType(types.XHR);

target._refreshRequest(requestFoo);

InspectorTest.addResult("Updated request [" + requestFoo.requestId + "] type.");

target._refreshRequest(requestBar);

@@ -37,8 +37,8 @@ function test() {

target.refresh();

InspectorTest.addResult("");

- InspectorTest.addResult("Request [" + requestFoo.requestId + "] of type '" + requestFoo.type.name() + "' is hidden: " + isFilteredOut(requestFoo));

- InspectorTest.addResult("Request [" + requestBar.requestId + "] of type '" + requestBar.type.name() + "' is hidden: " + isFilteredOut(requestBar));

+ InspectorTest.addResult("Request [" + requestFoo.requestId + "] of type '" + requestFoo.resourceType().name() + "' is hidden: " + isFilteredOut(requestFoo));

+ InspectorTest.addResult("Request [" + requestBar.requestId + "] of type '" + requestBar.resourceType().name() + "' is hidden: " + isFilteredOut(requestBar));

InspectorTest.completeTest();

}