Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Unified Diff: Source/devtools/front_end/network/RequestPreviewView.js

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/network/RequestPreviewView.js
diff --git a/Source/devtools/front_end/network/RequestPreviewView.js b/Source/devtools/front_end/network/RequestPreviewView.js
index 86819997269e121fa93d72c3f8dcafe7ce3957af..22227ffc3f8864d41bcf039fea4ac84eb546b49f 100644
--- a/Source/devtools/front_end/network/RequestPreviewView.js
+++ b/Source/devtools/front_end/network/RequestPreviewView.js
@@ -122,7 +122,7 @@ WebInspector.RequestPreviewView.prototype = {
return htmlErrorPreview;
}
- if (this.request.type === WebInspector.resourceTypes.XHR) {
+ if (this.request.resourceType() === WebInspector.resourceTypes.XHR) {
var jsonView = this._jsonView();
if (jsonView)
return jsonView;
@@ -134,7 +134,7 @@ WebInspector.RequestPreviewView.prototype = {
if (this._responseView.sourceView)
return this._responseView.sourceView;
- if (this.request.type === WebInspector.resourceTypes.Other)
+ if (this.request.resourceType() === WebInspector.resourceTypes.Other)
return this._createEmptyView();
return WebInspector.RequestView.nonSourceViewForRequest(this.request);
« no previous file with comments | « Source/devtools/front_end/network/NetworkPanel.js ('k') | Source/devtools/front_end/network/RequestResponseView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698