LayoutTests/http/tests/inspector/websocket/websocket-frame-error.html - Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/inspector/websocket/websocket-frame-error.html

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector/websocket/websocket-frame.html ('k') | LayoutTests/inspector/network/network-filter-updated-requests.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="/inspector/inspector-test.js"></script>	3 <script src="/inspector/inspector-test.js"></script>

4 <script src="/js-test-resources/js-test.js"></script>	4 <script src="/js-test-resources/js-test.js"></script>

5 <script>	5 <script>

6 var ws;	6 var ws;

7 function sendMessages() {	7 function sendMessages() {

8 ws = new WebSocket("ws://localhost:8000/does_not_exist");	8 ws = new WebSocket("ws://localhost:8000/does_not_exist");

9 ws.onclose = function()	9 ws.onclose = function()

10 {	10 {

11 debug("Closed.");	11 debug("Closed.");

12 };	12 };

13 }	13 }

14	14

15 function test() {	15 function test() {

16 function onRequest(event)	16 function onRequest(event)

17 {	17 {

18 var request = event.data;	18 var request = event.data;

19 if (request._type._name === "websocket") {	19 if (request.resourceType().name() === "websocket") {

20 var websocketFrames = request.frames();	20 var websocketFrames = request.frames();

21 for (var i = 0; i < websocketFrames.length; i++) {	21 for (var i = 0; i < websocketFrames.length; i++) {

22 var frame = websocketFrames[i];	22 var frame = websocketFrames[i];

23 var result = String.sprintf("%d-%s: %s", (i + 1), frame.type, fr ame.text);	23 var result = String.sprintf("%d-%s: %s", (i + 1), frame.type, fr ame.text);

24 InspectorTest.addResult(result);	24 InspectorTest.addResult(result);

25 if (frame.type == WebInspector.NetworkRequest.WebSocketFrameType .Error)	25 if (frame.type == WebInspector.NetworkRequest.WebSocketFrameType .Error)

26 InspectorTest.completeTest();	26 InspectorTest.completeTest();

27 }	27 }

28 }	28 }

29 }	29 }

30 WebInspector.networkManager.addEventListener(WebInspector.NetworkManager.Eve ntTypes.RequestUpdated, onRequest);	30 WebInspector.networkManager.addEventListener(WebInspector.NetworkManager.Eve ntTypes.RequestUpdated, onRequest);

31 InspectorTest.evaluateInPage("sendMessages()");	31 InspectorTest.evaluateInPage("sendMessages()");

32 }	32 }

33 </script>	33 </script>

34 </head>	34 </head>

35 <body onload="runTest()">	35 <body onload="runTest()">

36 <p>Tests that WebSocketFrames errors are visible to Web Inspector.</p>	36 <p>Tests that WebSocketFrames errors are visible to Web Inspector.</p>

37 </body>	37 </body>

38 </html>	38 </html>

OLD	NEW