Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: Source/devtools/front_end/audits/AuditRules.js

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/audits/AuditRules.js
diff --git a/Source/devtools/front_end/audits/AuditRules.js b/Source/devtools/front_end/audits/AuditRules.js
index c2aa0cc05b63b5cafa432bc63ab71fe4bb10b314..3a613fd0685db85364178db756437b442cec3f0a 100644
--- a/Source/devtools/front_end/audits/AuditRules.js
+++ b/Source/devtools/front_end/audits/AuditRules.js
@@ -53,7 +53,7 @@ WebInspector.AuditRules.getDomainToResourcesMap = function(requests, types, need
var domainToResourcesMap = {};
for (var i = 0, size = requests.length; i < size; ++i) {
var request = requests[i];
- if (types && types.indexOf(request.type) === -1)
+ if (types && types.indexOf(request.resourceType()) === -1)
continue;
var parsedURL = request.url.asParsedURL();
if (!parsedURL)
@@ -134,7 +134,7 @@ WebInspector.AuditRules.GzipRule.prototype = {
*/
_shouldCompress: function(request)
{
- return request.type.isTextType() && request.parsedURL.host && request.resourceSize !== undefined && request.resourceSize > 150;
+ return request.resourceType().isTextType() && request.parsedURL.host && request.resourceSize !== undefined && request.resourceSize > 150;
},
__proto__: WebInspector.AuditRule.prototype
@@ -414,7 +414,7 @@ WebInspector.AuditRules.UnusedCssRule.prototype = {
continue;
var resource = WebInspector.resourceForURL(styleSheet.sourceURL);
- var isInlineBlock = resource && resource.request && resource.request.type === WebInspector.resourceTypes.Document;
+ var isInlineBlock = resource && resource.request && resource.request.resourceType() === WebInspector.resourceTypes.Document;
var url = !isInlineBlock ? WebInspector.AuditRuleResult.linkifyDisplayName(styleSheet.sourceURL) : WebInspector.UIString("Inline block #%d", ++inlineBlockOrdinal);
var pctUnused = Math.round(100 * unusedRules.length / styleSheet.rules.length);
if (!summary)
@@ -677,7 +677,7 @@ WebInspector.AuditRules.CacheControlRule.prototype = {
*/
isCompressible: function(request)
{
- return request.type.isTextType();
+ return request.resourceType().isTextType();
},
/**

Powered by Google App Engine
This is Rietveld 408576698