Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/network/NetworkPanel.js
diff --git a/Source/devtools/front_end/network/NetworkPanel.js b/Source/devtools/front_end/network/NetworkPanel.js
index dc459e7f9785da85204ffaa91ae17464efc0a9ee..2c602ef7369e78270c40c77c8794ad2c7b552bb7 100644
--- a/Source/devtools/front_end/network/NetworkPanel.js
+++ b/Source/devtools/front_end/network/NetworkPanel.js
@@ -1218,7 +1218,7 @@ WebInspector.NetworkLogView.prototype = {
contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Clear browser cache" : "Clear Browser Cache"), this._clearBrowserCache.bind(this));
contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Clear browser cookies" : "Clear Browser Cookies"), this._clearBrowserCookies.bind(this));
- if (request && request.type === WebInspector.resourceTypes.XHR) {
+ if (request && request.resourceType() === WebInspector.resourceTypes.XHR) {
contextMenu.appendSeparator();
contextMenu.appendItem(WebInspector.UIString("Replay XHR"), this._replayXHR.bind(this, request.requestId));
contextMenu.appendSeparator();
@@ -1480,7 +1480,7 @@ WebInspector.NetworkLogView.prototype = {
_applyFilter: function(node)
{
var request = node.request();
- if (!this._resourceTypeFilterUI.accept(request.type.name()))
+ if (!this._resourceTypeFilterUI.accept(request.resourceType().name()))
return false;
if (this._dataURLFilterUI.checked() && request.parsedURL.isDataURL())
return false;
@@ -2779,7 +2779,7 @@ WebInspector.NetworkDataGridNode.prototype = {
this._barAreaElement = cell.createChild("div", "network-graph-bar-area");
this._barAreaElement.request = this._request;
- var type = this._request.type.name();
+ var type = this._request.resourceType().name();
var cached = this._request.cached();
this._barLeftElement = this._barAreaElement.createChild("div", "network-graph-bar");
@@ -2824,7 +2824,7 @@ WebInspector.NetworkDataGridNode.prototype = {
cell.addEventListener("click", this._onClick.bind(this), false);
cell.addEventListener("dblclick", this._openInNewTab.bind(this), false);
var iconElement;
- if (this._request.type === WebInspector.resourceTypes.Image) {
+ if (this._request.resourceType() === WebInspector.resourceTypes.Image) {
var previewImage = createElementWithClass("img", "image-network-icon-preview");
this._request.populateImageSource(previewImage);
@@ -2833,7 +2833,7 @@ WebInspector.NetworkDataGridNode.prototype = {
} else {
iconElement = createElementWithClass("img", "icon");
}
- iconElement.classList.add(this._request.type.name());
+ iconElement.classList.add(this._request.resourceType().name());
cell.appendChild(iconElement);
cell.createTextChild(this._request.name());
« no previous file with comments | « Source/devtools/front_end/network/NetworkItemView.js ('k') | Source/devtools/front_end/network/RequestPreviewView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698