LayoutTests/http/tests/inspector/network/network-iframe-load-and-delete.html - Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/inspector/network/network-iframe-load-and-delete.html

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html ('k') | LayoutTests/http/tests/inspector/network/network-image-404.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/inspector/network/network-iframe-load-and-delete.html

diff --git a/LayoutTests/http/tests/inspector/network/network-iframe-load-and-delete.html b/LayoutTests/http/tests/inspector/network/network-iframe-load-and-delete.html

index 432c61c3e93a6c67a7d2d0f4035d6b831bbb2f8e..6c4a1d0e32c40173d7ffe8cd51c0142626b0e34c 100644

--- a/LayoutTests/http/tests/inspector/network/network-iframe-load-and-delete.html

+++ b/LayoutTests/http/tests/inspector/network/network-iframe-load-and-delete.html

@@ -47,7 +47,7 @@ function test()

var requests = InspectorTest.networkRequests();

var request1 = requests[requests.length - 2];

InspectorTest.addResult(request1.url);

- InspectorTest.addResult("resource.type: " + request1.type);

+ InspectorTest.addResult("resource.type: " + request1.resourceType());

InspectorTest.addResult("resource.content before requesting content: " + request1.content);

request1.requestContent(step3);

}

@@ -60,7 +60,7 @@ function test()

var request2 = requests[requests.length - 1];

InspectorTest.addResult(request2.url);

- InspectorTest.addResult("resource.type: " + request2.type);

+ InspectorTest.addResult("resource.type: " + request2.resourceType());

InspectorTest.addResult("resource.content before requesting content: " + request2.content);

request2.requestContent(step4);

}