LayoutTests/http/tests/inspector/network/network-image-404.html - Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/inspector/network/network-image-404.html

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector/network/network-iframe-load-and-delete.html ('k') | LayoutTests/http/tests/inspector/network/network-xhr-async.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../inspector-test.js"></script>	3 <script src="../inspector-test.js"></script>

4 <script src="../network-test.js"></script>	4 <script src="../network-test.js"></script>

5 <script>	5 <script>

6 function loadData()	6 function loadData()

7 {	7 {

8 var image = new Image();	8 var image = new Image();

9 image.src = "resources/404.php";	9 image.src = "resources/404.php";

10 image.onerror = resourceLoaded;	10 image.onerror = resourceLoaded;

(...skipping 14 matching lines...) Expand all Loading...
25 {	25 {

26 InspectorTest.recordNetwork();	26 InspectorTest.recordNetwork();

27 InspectorTest.addConsoleSniffer(step2);	27 InspectorTest.addConsoleSniffer(step2);

28 InspectorTest.evaluateInPage("loadData()");	28 InspectorTest.evaluateInPage("loadData()");

29 }	29 }

30	30

31 function step2()	31 function step2()

32 {	32 {

33 var request1 = InspectorTest.networkRequests().pop();	33 var request1 = InspectorTest.networkRequests().pop();

34 InspectorTest.addResult(request1.url);	34 InspectorTest.addResult(request1.url);

35 InspectorTest.addResult("resource.type: " + request1.type);	35 InspectorTest.addResult("resource.type: " + request1.resourceType());

36 InspectorTest.addResult("resource.content before requesting content: " + request1.content);	36 InspectorTest.addResult("resource.content before requesting content: " + request1.content);

37 InspectorTest.assertTrue(!request1.failed, "Resource loading failed.");	37 InspectorTest.assertTrue(!request1.failed, "Resource loading failed.");

38 request1.requestContent(step3);	38 request1.requestContent(step3);

39 }	39 }

40	40

41 function step3()	41 function step3()

42 {	42 {

43 var request1 = InspectorTest.networkRequests().pop();	43 var request1 = InspectorTest.networkRequests().pop();

44 InspectorTest.addResult("resource.content after requesting content: " + request1.content);	44 InspectorTest.addResult("resource.content after requesting content: " + request1.content);

45	45

46 InspectorTest.completeTest();	46 InspectorTest.completeTest();

47 }	47 }

48 }	48 }

49 </script>	49 </script>

50 </head>	50 </head>

51 <body onload="runTest()">	51 <body onload="runTest()">

52 <p>Tests content is available for failed image request.</p>	52 <p>Tests content is available for failed image request.</p>

53 <a href="https://bugs.webkit.org/show_bug.cgi?id=84265">Bug 84265</a>	53 <a href="https://bugs.webkit.org/show_bug.cgi?id=84265">Bug 84265</a>

54 </body>	54 </body>

55 </html>	55 </html>

OLD	NEW