LayoutTests/http/tests/inspector/network/network-xhr-binary-content.html - Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/inspector/network/network-xhr-binary-content.html

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector/network/network-xhr-async-response-type-blob.html ('k') | LayoutTests/http/tests/inspector/network/network-xhr-same-url-as-main-resource.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../inspector-test.js"></script>	3 <script src="../inspector-test.js"></script>

4 <script src="../network-test.js"></script>	4 <script src="../network-test.js"></script>

5 <script>	5 <script>

6	6

7 function test()	7 function test()

8 {	8 {

9 InspectorTest.recordNetwork();	9 InspectorTest.recordNetwork();

10 InspectorTest.makeSimpleXHR("GET", "resources/binary.data", true, step2);	10 InspectorTest.makeSimpleXHR("GET", "resources/binary.data", true, step2);

11	11

12 function step2()	12 function step2()

13 {	13 {

14 var request = InspectorTest.networkRequests().pop();	14 var request = InspectorTest.networkRequests().pop();

15 InspectorTest.addResult("request.type: " + request.type);	15 InspectorTest.addResult("request.type: " + request.resourceType());

16 InspectorTest.addResult("request.mimeType: " + request.mimeType);	16 InspectorTest.addResult("request.mimeType: " + request.mimeType);

17 request.requestContent(step3);	17 request.requestContent(step3);

18 }	18 }

19	19

20 function step3()	20 function step3()

21 {	21 {

22 var request = InspectorTest.networkRequests().pop();	22 var request = InspectorTest.networkRequests().pop();

23 InspectorTest.addResult("request.contentEncoded: " + request.contentEnco ded);	23 InspectorTest.addResult("request.contentEncoded: " + request.contentEnco ded);

24 InspectorTest.addResult("request.content: " + request.content);	24 InspectorTest.addResult("request.content: " + request.content);

25 var raw = window.atob(request.content);	25 var raw = window.atob(request.content);

26 var bytes = [];	26 var bytes = [];

27 for (var i = 0; i < raw.length; ++i)	27 for (var i = 0; i < raw.length; ++i)

28 bytes.push(raw.charCodeAt(i));	28 bytes.push(raw.charCodeAt(i));

29 InspectorTest.addResult("request.content decoded: " + bytes.join(", "));	29 InspectorTest.addResult("request.content decoded: " + bytes.join(", "));

30 InspectorTest.completeTest();	30 InspectorTest.completeTest();

31 }	31 }

32 }	32 }

33 </script>	33 </script>

34 </head>	34 </head>

35 <body onload="runTest()">	35 <body onload="runTest()">

36 <p>Tests that binary XHR response is not corrupted.</p>	36 <p>Tests that binary XHR response is not corrupted.</p>

37 </body>	37 </body>

38 </html>	38 </html>

OLD	NEW