Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

Using FileVersionInfo to fill the VersionInfo causes at least three sync IPCs
when used from the renderer. This is used when filling the user agent string
for every network request, so having it not do the sync ipcs is... better.

So, use the previously posix-only path on Windows and Mac too, since it's
simpler anyway.

R=thestig@chromium.org, cpu@chromium.org
BUG=417941, 402714
Committed: https://crrev.com/2e462536b035b662e86e0b2cf392c8315dfc17db
Cr-Commit-Position: refs/heads/master@{#298319}

[scottmg, 2014-10-06 17:25:32]

scottmg@chromium.org changed reviewers:
+ cpu@chromium.org

[scottmg, 2014-10-06 17:29:15]

scottmg@chromium.org changed reviewers:
+ thestig@chromium.org
- cpu@chromium.org

[scottmg, 2014-10-06 17:31:10]

scottmg@chromium.org changed reviewers:
+ cpu@chromium.org

[Alexei Svitkine (slow), 2014-10-06 17:38:00]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2014-10-06 17:38:01]

Sweet, this should also fix
https://code.google.com/p/chromium/issues/detail?id=402714

[Alexei Svitkine (slow), 2014-10-06 17:39:14]

asvitkine@chromium.org changed reviewers:
- asvitkine@chromium.org

[cpu_(ooo_6.6-7.5), 2014-10-06 18:19:17]

https://codereview.chromium.org/634583003/diff/20001/chrome/common/chrome_ver...
File chrome/common/chrome_version_info_values.h.version (left):

https://codereview.chromium.org/634583003/diff/20001/chrome/common/chrome_ver...
chrome/common/chrome_version_info_values.h.version:13: #endif  //
CHROME_COMMON_CHROME_VERSION_INFO_POSIX_H_
"INFO_POSIX" ?

[scottmg, 2014-10-06 18:20:39]

thanks

https://codereview.chromium.org/634583003/diff/20001/chrome/common/chrome_ver...
File chrome/common/chrome_version_info_values.h.version (left):

https://codereview.chromium.org/634583003/diff/20001/chrome/common/chrome_ver...
chrome/common/chrome_version_info_values.h.version:13: #endif  //
CHROME_COMMON_CHROME_VERSION_INFO_POSIX_H_
On 2014/10/06 18:19:17, cpu wrote:
> "INFO_POSIX" ?

Done.

[cpu_(ooo_6.6-7.5), 2014-10-06 19:21:43]

lgtm

[Lei Zhang, 2014-10-06 19:22:52]

https://codereview.chromium.org/634583003/diff/40001/chrome/browser/diagnosti...
File chrome/browser/diagnostics/recon_diagnostics.cc (left):

https://codereview.chromium.org/634583003/diff/40001/chrome/browser/diagnosti...
chrome/browser/diagnostics/recon_diagnostics.cc:363:
RecordFailure(DIAG_RECON_NO_VERSION, "No Version");
DIAG_RECON_NO_VERSION is no longer used, but I'm not sure if we can get rid of
the enum. You'll have to ask cpu.

[Lei Zhang, 2014-10-06 19:24:49]

otherwise lgtm

[cpu_(ooo_6.6-7.5), 2014-10-06 19:27:43]

https://codereview.chromium.org/634583003/diff/40001/chrome/browser/diagnosti...
File chrome/browser/diagnostics/recon_diagnostics.cc (left):

https://codereview.chromium.org/634583003/diff/40001/chrome/browser/diagnosti...
chrome/browser/diagnostics/recon_diagnostics.cc:363:
RecordFailure(DIAG_RECON_NO_VERSION, "No Version");
On 2014/10/06 19:22:52, Lei Zhang wrote:
> DIAG_RECON_NO_VERSION is no longer used, but I'm not sure if we can get rid of
> the enum. You'll have to ask cpu.

This might be used by CroS. Sad times.

[scottmg, 2014-10-06 19:28:58]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-10-06 19:31:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/634583003/40001

[scottmg, 2014-10-06 20:37:44]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-10-06 20:38:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/634583003/60001

[commit-bot: I haz the power, 2014-10-06 23:19:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-06 23:19:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scottmg, 2014-10-07 00:09:40]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-10-07 00:11:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/634583003/60001

[commit-bot: I haz the power, 2014-10-07 02:10:14]

Committed patchset #4 (id:60001) as 4ab4af85626ab1c4ccb98cccc40684eced55fb1a

[commit-bot: I haz the power, 2014-10-07 02:11:17]

Patchset 4 (id:??) landed as
https://crrev.com/2e462536b035b662e86e0b2cf392c8315dfc17db
Cr-Commit-Position: refs/heads/master@{#298319}