Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

chrome/browser/sync/glue/local_device_info_provider_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "chrome/browser/sync/glue/local_device_info_provider_impl.h"
 #include "chrome/common/chrome_version_info.h"
 #include "content/public/browser/browser_thread.h"
 #include "sync/util/get_session_name.h"
 #include "ui/base/device_form_factor.h"
@@ skipping 69 matching lines @@
     user_agent += "ANDROID-PHONE ";
 #elif defined(OS_LINUX)
   user_agent += "LINUX ";
 #elif defined(OS_FREEBSD)
   user_agent += "FREEBSD ";
 #elif defined(OS_OPENBSD)
   user_agent += "OPENBSD ";
 #elif defined(OS_MACOSX)
   user_agent += "MAC ";
 #endif
-  if (!version_info.is_valid()) {
-    DLOG(ERROR) << "Unable to create chrome::VersionInfo object";
-    return user_agent;
-  }
-
   user_agent += version_info.Version();
   user_agent += " (" + version_info.LastChange() + ")";
   if (!version_info.IsOfficialBuild()) {
     user_agent += "-devel";
   } else {
     user_agent +=
         " channel(" + ChannelToString(version_info.GetChannel()) + ")";
   }
 
   return user_agent;
@@ skipping 40 matching lines @@
                                   version_info.CreateVersionString(),
                                   MakeUserAgentForSyncApi(version_info),
                                   GetLocalDeviceType(),
                                   signin_scoped_device_id));
 
   // Notify observers.
   callback_list_.Notify();
 }
 
 }  // namespace browser_sync