Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

chrome/browser/sync/about_sync_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/about_sync_util.h"
 
 #include <string>
 
 #include "base/strings/string16.h"
 #include "base/strings/stringprintf.h"
@@ skipping 125 matching lines @@
 
 // Returns a string describing the chrome version environment. Version format:
 // <Build Info> <OS> <Version number> (<Last change>)<channel or "-devel">
 // If version information is unavailable, returns "invalid."
 // TODO(zea): this approximately matches MakeUserAgentForSyncApi in
 // sync_backend_host.cc. Unify the two if possible.
 std::string GetVersionString() {
   // Build a version string that matches MakeUserAgentForSyncApi with the
   // addition of channel info and proper OS names.
   chrome::VersionInfo chrome_version;
-  if (!chrome_version.is_valid())
-    return "invalid";
   // GetVersionStringModifier returns empty string for stable channel or
   // unofficial builds, the channel string otherwise. We want to have "-devel"
   // for unofficial builds only.
   std::string version_modifier =
       chrome::VersionInfo::GetVersionStringModifier();
   if (version_modifier.empty()) {
     if (chrome::VersionInfo::GetChannel() !=
             chrome::VersionInfo::CHANNEL_STABLE) {
       version_modifier = "-devel";
     }
@@ skipping 330 matching lines @@
     about_info->SetString("unrecoverable_error_message",
                        unrecoverable_error_message);
   }
 
   about_info->Set("type_status", service->GetTypeStatusMap());
 
   return about_info.Pass();
 }
 
 }  // namespace sync_ui_util