Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

chrome/browser/signin/chrome_signin_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/chrome_signin_client.h"
 
 #include "base/command_line.h"
 #include "base/guid.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 159 matching lines @@
 
 bool ChromeSigninClient::ShouldMergeSigninCredentialsIntoCookieJar() {
   // If inline sign in is enabled, but account consistency is not, the user's
   // credentials should be merge into the cookie jar.
   return !switches::IsEnableWebBasedSignin() &&
          !switches::IsEnableAccountConsistency();
 }
 
 std::string ChromeSigninClient::GetProductVersion() {
   chrome::VersionInfo chrome_version;
-  if (!chrome_version.is_valid())
-    return "invalid";
   return chrome_version.CreateVersionString();
 }
 
 bool ChromeSigninClient::IsFirstRun() const {
 #if defined(OS_ANDROID)
   return false;
 #else
   return first_run::IsChromeFirstRun();
 #endif
 }
@@ skipping 52 matching lines @@
   if (!callbacks_.empty())
     return;
   // Note that it's allowed to call this method multiple times without an
   // intervening call to |RegisterForCookieChangedNotification()|.
   content::Source<Profile> source(profile_);
   if (!registrar_.IsRegistered(
       this, chrome::NOTIFICATION_COOKIE_CHANGED, source))
     return;
   registrar_.Remove(this, chrome::NOTIFICATION_COOKIE_CHANGED, source);
 }