chrome/browser/ui/webui/help/help_handler.cc - Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/help/help_handler.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: linux include Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/help/help_handler.cc

diff --git a/chrome/browser/ui/webui/help/help_handler.cc b/chrome/browser/ui/webui/help/help_handler.cc

index 603e2b764ae751b1790f56f2e975da1c3dd58e81..b28ff496ed06539d74da6f8324625862bbe3120a 100644

--- a/chrome/browser/ui/webui/help/help_handler.cc

+++ b/chrome/browser/ui/webui/help/help_handler.cc

@@ -312,7 +312,6 @@ void HelpHandler::Observe(int type, const content::NotificationSource& source,

// static

base::string16 HelpHandler::BuildBrowserVersionString() {

chrome::VersionInfo version_info;

- DCHECK(version_info.is_valid());

std::string version = version_info.Version();

« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/webui/net_internals/net_internals_ui.cc » ('j') | no next file with comments »