Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

chrome/browser/memory_details_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/memory_details.h"
 
 #include <set>
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 197 matching lines @@
     base::ProcessId pid,
     const ProcessInfoSnapshot& process_info) {
   ProcessMemoryInformation info;
   info.pid = pid;
   if (info.pid == base::GetCurrentProcId())
     info.process_type = content::PROCESS_TYPE_BROWSER;
   else
     info.process_type = content::PROCESS_TYPE_UNKNOWN;
 
   chrome::VersionInfo version_info;
-  if (version_info.is_valid()) {
-    info.product_name = base::ASCIIToUTF16(version_info.Name());
-    info.version = base::ASCIIToUTF16(version_info.Version());
-  } else {
-    info.product_name = process_data_[CHROME_BROWSER].name;
-    info.version = base::string16();
-  }
+  info.product_name = base::ASCIIToUTF16(version_info.Name());
+  info.version = base::ASCIIToUTF16(version_info.Version());
 
   // Check if this is one of the child processes whose data we collected
   // on the IO thread, and if so copy over that data.
   for (size_t child = 0; child < child_info.size(); child++) {
     if (child_info[child].pid == info.pid) {
       info.titles = child_info[child].titles;
       info.process_type = child_info[child].process_type;
       break;
     }
   }
 
   // Memory info.
   process_info.GetCommittedKBytesOfPID(info.pid, &info.committed);
   process_info.GetWorkingSetKBytesOfPID(info.pid, &info.working_set);
 
   // Add the process info to our list.
   process_data_[CHROME_BROWSER].processes.push_back(info);
 }