chrome/common/chrome_content_client_ios.mm - Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_content_client_ios.mm

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: linux include Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/chrome_content_client_ios.mm

diff --git a/chrome/common/chrome_content_client_ios.mm b/chrome/common/chrome_content_client_ios.mm

index 52a8d3dc74d9e9a6cbe31617aec48b0952f14c7f..baee77c9329925cc766bc1719baca8ef4eecad4a 100644

--- a/chrome/common/chrome_content_client_ios.mm

+++ b/chrome/common/chrome_content_client_ios.mm

@@ -38,7 +38,7 @@ void ChromeContentClient::AddAdditionalSchemes(

std::string ChromeContentClient::GetProduct() const {

chrome::VersionInfo version_info;

std::string product("CriOS/");

- product += version_info.is_valid() ? version_info.Version() : "0.0.0.0";

+ product += version_info.Version();

return product;

}

« no previous file with comments | « chrome/common/chrome_content_client.cc ('k') | chrome/common/chrome_version_info.h » ('j') | no next file with comments »