Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: chrome/common/chrome_version_info.h

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: linux include Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/chrome_content_client_ios.mm ('k') | chrome/common/chrome_version_info.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_CHROME_VERSION_INFO_H_ 5 #ifndef CHROME_COMMON_CHROME_VERSION_INFO_H_
6 #define CHROME_COMMON_CHROME_VERSION_INFO_H_ 6 #define CHROME_COMMON_CHROME_VERSION_INFO_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 12 matching lines...) Expand all
23 CHANNEL_UNKNOWN = 0, // Probably blue 23 CHANNEL_UNKNOWN = 0, // Probably blue
24 CHANNEL_CANARY, // Yellow 24 CHANNEL_CANARY, // Yellow
25 CHANNEL_DEV, // Technicolor 25 CHANNEL_DEV, // Technicolor
26 CHANNEL_BETA, // Rainbow 26 CHANNEL_BETA, // Rainbow
27 CHANNEL_STABLE // Full-spectrum 27 CHANNEL_STABLE // Full-spectrum
28 }; 28 };
29 29
30 VersionInfo(); 30 VersionInfo();
31 ~VersionInfo(); 31 ~VersionInfo();
32 32
33 // In the rare case where we fail to get the version info,
34 // is_valid() will return false. The other functions will return
35 // the empty string in this case, so it's not harmful if you don't
36 // check is_valid().
37 bool is_valid() const;
38
39 // E.g. "Chrome/a.b.c.d" 33 // E.g. "Chrome/a.b.c.d"
40 std::string ProductNameAndVersionForUserAgent() const; 34 std::string ProductNameAndVersionForUserAgent() const;
41 35
42 // E.g. "Chromium" or "Google Chrome". 36 // E.g. "Chromium" or "Google Chrome".
43 std::string Name() const; 37 std::string Name() const;
44 38
45 // Version number, e.g. "6.0.490.1". 39 // Version number, e.g. "6.0.490.1".
46 std::string Version() const; 40 std::string Version() const;
47 41
48 // The SVN revision of this release. E.g. "55800". 42 // The SVN revision of this release. E.g. "55800".
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 #if defined(OS_WIN) || defined(OS_MACOSX) 80 #if defined(OS_WIN) || defined(OS_MACOSX)
87 scoped_ptr<FileVersionInfo> version_info_; 81 scoped_ptr<FileVersionInfo> version_info_;
88 #endif 82 #endif
89 83
90 DISALLOW_COPY_AND_ASSIGN(VersionInfo); 84 DISALLOW_COPY_AND_ASSIGN(VersionInfo);
91 }; 85 };
92 86
93 } // namespace chrome 87 } // namespace chrome
94 88
95 #endif // CHROME_COMMON_CHROME_VERSION_INFO_H_ 89 #endif // CHROME_COMMON_CHROME_VERSION_INFO_H_
OLDNEW
« no previous file with comments | « chrome/common/chrome_content_client_ios.mm ('k') | chrome/common/chrome_version_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698