chrome/browser/upgrade_detector_impl.cc - Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/upgrade_detector_impl.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: linux include Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/upgrade_detector_impl.cc

diff --git a/chrome/browser/upgrade_detector_impl.cc b/chrome/browser/upgrade_detector_impl.cc

index e61d2f86e2fc3d2dd3420c28726fdcb3ac5ce810..bc0e4c78404b1ab27796334ff8f98a8a7b700a8b 100644

--- a/chrome/browser/upgrade_detector_impl.cc

+++ b/chrome/browser/upgrade_detector_impl.cc

@@ -315,10 +315,6 @@ void UpgradeDetectorImpl::DetectUpgradeTask(

// Get the version of the currently *running* instance of Chrome.

chrome::VersionInfo version_info;

- if (!version_info.is_valid()) {

- NOTREACHED() << "Failed to get current file version";

- return;

- }

Version running_version(version_info.Version());

if (!running_version.IsValid()) {

NOTREACHED();

« no previous file with comments | « chrome/browser/ui/webui/net_internals/net_internals_ui.cc ('k') | chrome/chrome_common.gypi » ('j') | no next file with comments »