Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4142)

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: linux include Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/help/help_handler.cc ('k') | chrome/browser/upgrade_detector_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/net_internals/net_internals_ui.cc
diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
index cfd781b97f6ee53a8a71415e3717e2cd3071a75c..262db3649172534b2856b02ee3a1a87988a264ad 100644
--- a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
@@ -1705,22 +1705,17 @@ base::Value* NetInternalsUI::GetConstants() {
chrome::VersionInfo version_info;
- if (!version_info.is_valid()) {
- DLOG(ERROR) << "Unable to create chrome::VersionInfo";
- } else {
- // We have everything we need to send the right values.
- dict->SetString("name", version_info.Name());
- dict->SetString("version", version_info.Version());
- dict->SetString("cl", version_info.LastChange());
- dict->SetString("version_mod",
- chrome::VersionInfo::GetVersionStringModifier());
- dict->SetString("official",
- version_info.IsOfficialBuild() ? "official" :
- "unofficial");
- dict->SetString("os_type", version_info.OSType());
- dict->SetString("command_line",
- CommandLine::ForCurrentProcess()->GetCommandLineString());
- }
+ // We have everything we need to send the right values.
+ dict->SetString("name", version_info.Name());
+ dict->SetString("version", version_info.Version());
+ dict->SetString("cl", version_info.LastChange());
+ dict->SetString("version_mod",
+ chrome::VersionInfo::GetVersionStringModifier());
+ dict->SetString("official",
+ version_info.IsOfficialBuild() ? "official" : "unofficial");
+ dict->SetString("os_type", version_info.OSType());
+ dict->SetString("command_line",
+ CommandLine::ForCurrentProcess()->GetCommandLineString());
constants_dict->Set("clientInfo", dict);
}
« no previous file with comments | « chrome/browser/ui/webui/help/help_handler.cc ('k') | chrome/browser/upgrade_detector_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698