Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6292)

Unified Diff: chrome/browser/safe_browsing/protocol_manager_helper.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: linux include Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/protocol_manager_helper.cc
diff --git a/chrome/browser/safe_browsing/protocol_manager_helper.cc b/chrome/browser/safe_browsing/protocol_manager_helper.cc
index 40846ed221b3ed2d41b5daa5fd58910d31fb821c..2066a8cb08408a690b8800c0aa7d5cc141ebe888 100644
--- a/chrome/browser/safe_browsing/protocol_manager_helper.cc
+++ b/chrome/browser/safe_browsing/protocol_manager_helper.cc
@@ -31,7 +31,7 @@ SafeBrowsingProtocolConfig::~SafeBrowsingProtocolConfig() {
// static
std::string SafeBrowsingProtocolManagerHelper::Version() {
chrome::VersionInfo version_info;
- if (!version_info.is_valid() || version_info.Version().empty())
+ if (version_info.Version().empty())
return "0.1";
else
return version_info.Version();

Powered by Google App Engine
This is Rietveld 408576698