chrome/common/BUILD.gn - Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/BUILD.gn

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: linux include Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/BUILD.gn

diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn

index 98a612bb6f1eb487f54a3361f56a00bce44c715e..4257fe6a1cbb03c9b97779258a03f2962bb8e8ae 100644

--- a/chrome/common/BUILD.gn

+++ b/chrome/common/BUILD.gn

@@ -241,12 +241,8 @@ if (is_linux || is_android) {

import("//chrome/version.gni")

process_version("version") {

visibility = [ ":common" ]

- source = "chrome_version_info_posix.h.version"

- output = "$target_gen_dir/chrome_version_info_posix.h"

- }

-} else {

- # Other platforms have a different way to do versioning.

- group("version") {

+ source = "chrome_version_info_values.h.version"

+ output = "$target_gen_dir/chrome_version_info_values.h"

}

« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/chrome_content_client.cc » ('j') | no next file with comments »