chrome/common/service_process_util_unittest.cc - Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/service_process_util_unittest.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: linux include Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/service_process_util_unittest.cc

diff --git a/chrome/common/service_process_util_unittest.cc b/chrome/common/service_process_util_unittest.cc

index 8133011d360f765b255896eea0eb1521b105086a..f9b79c99247d148183a3c7b1f11204f15ebadbb3 100644

--- a/chrome/common/service_process_util_unittest.cc

+++ b/chrome/common/service_process_util_unittest.cc

@@ -61,7 +61,6 @@ TEST(ServiceProcessUtilTest, ScopedVersionedName) {

std::string test_str = "test";

std::string scoped_name = GetServiceProcessScopedVersionedName(test_str);

chrome::VersionInfo version_info;

- DCHECK(version_info.is_valid());

EXPECT_TRUE(EndsWith(scoped_name, test_str, true));

EXPECT_NE(std::string::npos, scoped_name.find(version_info.Version()));

}

« no previous file with comments | « chrome/common/service_process_util_mac.mm ('k') | chrome/service/net/service_url_request_context_getter.cc » ('j') | no next file with comments »