Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 629913002: Replacing the OVERRIDE with override and FINAL with final in gpu (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
no sievers
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in gpu This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/5e1b895bbc15d452ce8df0b18a0f3ca8d11ccd9c Cr-Commit-Position: refs/heads/master@{#298634}

Patch Set 1 #

Patch Set 2 : Included autogen python file for OVERRIDE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1116 lines, -1116 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 4 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/buffer_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/client_test_helper.h View 2 chunks +13 lines, -13 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 2 chunks +12 lines, -12 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 15 chunks +211 lines, -211 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 3 chunks +14 lines, -14 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 12 chunks +215 lines, -215 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 12 chunks +215 lines, -215 lines 0 comments Download
M gpu/command_buffer/client/program_info_manager.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M gpu/command_buffer/client/share_group.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M gpu/command_buffer/client/transfer_buffer.h View 1 chunk +10 lines, -10 lines 0 comments Download
M gpu/command_buffer/client/transfer_buffer_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/common/buffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_egl.h View 2 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_egl.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_idle.h View 2 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_idle.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_share_group.h View 2 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_stub.h View 1 chunk +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_stub.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_sync.h View 2 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_sync.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service.h View 1 chunk +14 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/common_decoder_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/error_state.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 9 chunks +34 lines, -34 lines 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.h View 1 chunk +12 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/gl_state_restorer_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 7 chunks +59 lines, -59 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 3 chunks +9 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_extensions.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gpu_service_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_state_tracer.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_tracer.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_tracer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 1 chunk +20 lines, -20 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/memory_program_cache.h View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/program_cache_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 8 chunks +29 lines, -29 lines 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/shader_translator_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/stream_texture_manager_in_process_android.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 3 chunks +26 lines, -26 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/transfer_buffer_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/transfer_buffer_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 1 chunk +10 lines, -10 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/tests/gl_unittests_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/config/gpu_control_list_entry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_test_config.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.h View 1 chunk +10 lines, -10 lines 0 comments Download
M gpu/tools/compositor_model_bench/forward_render_model.h View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/tools/compositor_model_bench/forward_render_model.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/tools/compositor_model_bench/render_model_utils.h View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/tools/compositor_model_bench/render_tree.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 09:00:05 UTC) #2
no sievers
For the "*_autogen.cc/.h" files you have to edit gpu/command_buffer/build_gles2_cmd_buffer.py (look for 'OVERRIDE' in there), then ...
6 years, 2 months ago (2014-10-06 17:57:53 UTC) #3
MRV
On 2014/10/06 17:57:53, sievers wrote: > For the "*_autogen.cc/.h" files you have to edit > ...
6 years, 2 months ago (2014-10-07 07:09:04 UTC) #4
no sievers
lgtm
6 years, 2 months ago (2014-10-07 17:39:38 UTC) #5
MRV
On 2014/10/07 17:39:38, sievers wrote: > lgtm Thanks mr.sievers.
6 years, 2 months ago (2014-10-08 00:35:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629913002/20001
6 years, 2 months ago (2014-10-08 00:36:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 575096fa165a9da5cb5f0dd232077bafdce2807c
6 years, 2 months ago (2014-10-08 01:38:25 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 01:40:40 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5e1b895bbc15d452ce8df0b18a0f3ca8d11ccd9c
Cr-Commit-Position: refs/heads/master@{#298634}

Powered by Google App Engine
This is Rietveld 408576698