Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Side by Side Diff: gpu/command_buffer/service/common_decoder_unittest.cc

Issue 629913002: Replacing the OVERRIDE with override and FINAL with final in gpu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Included autogen python file for OVERRIDE Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/common_decoder.h" 5 #include "gpu/command_buffer/service/common_decoder.h"
6 #include "gpu/command_buffer/service/cmd_buffer_engine.h" 6 #include "gpu/command_buffer/service/cmd_buffer_engine.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace gpu { 9 namespace gpu {
10 10
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 EXPECT_EQ(0, memcmp(data, bucket.GetData(0, sizeof(data)), sizeof(data))); 44 EXPECT_EQ(0, memcmp(data, bucket.GetData(0, sizeof(data)), sizeof(data)));
45 EXPECT_TRUE(bucket.SetData(data, 2, sizeof(data))); 45 EXPECT_TRUE(bucket.SetData(data, 2, sizeof(data)));
46 EXPECT_EQ(0, memcmp(data, bucket.GetData(2, sizeof(data)), sizeof(data))); 46 EXPECT_EQ(0, memcmp(data, bucket.GetData(2, sizeof(data)), sizeof(data)));
47 EXPECT_FALSE(bucket.SetData(data, 0, sizeof(data) * 2)); 47 EXPECT_FALSE(bucket.SetData(data, 0, sizeof(data) * 2));
48 EXPECT_FALSE(bucket.SetData(data, 5, sizeof(data))); 48 EXPECT_FALSE(bucket.SetData(data, 5, sizeof(data)));
49 } 49 }
50 50
51 class TestCommonDecoder : public CommonDecoder { 51 class TestCommonDecoder : public CommonDecoder {
52 public: 52 public:
53 // Overridden from AsyncAPIInterface 53 // Overridden from AsyncAPIInterface
54 virtual const char* GetCommandName(unsigned int command_id) const OVERRIDE { 54 virtual const char* GetCommandName(unsigned int command_id) const override {
55 return GetCommonCommandName(static_cast<cmd::CommandId>(command_id)); 55 return GetCommonCommandName(static_cast<cmd::CommandId>(command_id));
56 } 56 }
57 57
58 // Overridden from AsyncAPIInterface 58 // Overridden from AsyncAPIInterface
59 virtual error::Error DoCommand( 59 virtual error::Error DoCommand(
60 unsigned int command, 60 unsigned int command,
61 unsigned int arg_count, 61 unsigned int arg_count,
62 const void* cmd_data) OVERRIDE { 62 const void* cmd_data) override {
63 return DoCommonCommand(command, arg_count, cmd_data); 63 return DoCommonCommand(command, arg_count, cmd_data);
64 } 64 }
65 65
66 CommonDecoder::Bucket* GetBucket(uint32 id) const { 66 CommonDecoder::Bucket* GetBucket(uint32 id) const {
67 return CommonDecoder::GetBucket(id); 67 return CommonDecoder::GetBucket(id);
68 } 68 }
69 }; 69 };
70 70
71 class MockCommandBufferEngine : public CommandBufferEngine { 71 class MockCommandBufferEngine : public CommandBufferEngine {
72 public: 72 public:
73 static const int32 kStartValidShmId = 1; 73 static const int32 kStartValidShmId = 1;
74 static const int32 kValidShmId = 2; 74 static const int32 kValidShmId = 2;
75 static const int32 kInvalidShmId = 3; 75 static const int32 kInvalidShmId = 3;
76 static const size_t kBufferSize = 1024; 76 static const size_t kBufferSize = 1024;
77 static const int32 kValidOffset = kBufferSize / 2; 77 static const int32 kValidOffset = kBufferSize / 2;
78 static const int32 kInvalidOffset = kBufferSize; 78 static const int32 kInvalidOffset = kBufferSize;
79 79
80 MockCommandBufferEngine() 80 MockCommandBufferEngine()
81 : CommandBufferEngine(), 81 : CommandBufferEngine(),
82 token_(), 82 token_(),
83 get_offset_(0) { 83 get_offset_(0) {
84 scoped_ptr<base::SharedMemory> shared_memory(new base::SharedMemory()); 84 scoped_ptr<base::SharedMemory> shared_memory(new base::SharedMemory());
85 shared_memory->CreateAndMapAnonymous(kBufferSize); 85 shared_memory->CreateAndMapAnonymous(kBufferSize);
86 buffer_ = MakeBufferFromSharedMemory(shared_memory.Pass(), kBufferSize); 86 buffer_ = MakeBufferFromSharedMemory(shared_memory.Pass(), kBufferSize);
87 } 87 }
88 88
89 // Overridden from CommandBufferEngine. 89 // Overridden from CommandBufferEngine.
90 virtual scoped_refptr<gpu::Buffer> GetSharedMemoryBuffer(int32 shm_id) 90 virtual scoped_refptr<gpu::Buffer> GetSharedMemoryBuffer(int32 shm_id)
91 OVERRIDE { 91 override {
92 if (IsValidSharedMemoryId(shm_id)) 92 if (IsValidSharedMemoryId(shm_id))
93 return buffer_; 93 return buffer_;
94 return NULL; 94 return NULL;
95 } 95 }
96 96
97 template <typename T> 97 template <typename T>
98 T GetSharedMemoryAs(uint32 offset) { 98 T GetSharedMemoryAs(uint32 offset) {
99 DCHECK_LT(offset, kBufferSize); 99 DCHECK_LT(offset, kBufferSize);
100 int8* buffer_memory = static_cast<int8*>(buffer_->memory()); 100 int8* buffer_memory = static_cast<int8*>(buffer_->memory());
101 return reinterpret_cast<T>(&buffer_memory[offset]); 101 return reinterpret_cast<T>(&buffer_memory[offset]);
102 } 102 }
103 103
104 int32 GetSharedMemoryOffset(const void* memory) { 104 int32 GetSharedMemoryOffset(const void* memory) {
105 int8* buffer_memory = static_cast<int8*>(buffer_->memory()); 105 int8* buffer_memory = static_cast<int8*>(buffer_->memory());
106 ptrdiff_t offset = static_cast<const int8*>(memory) - &buffer_memory[0]; 106 ptrdiff_t offset = static_cast<const int8*>(memory) - &buffer_memory[0];
107 DCHECK_GE(offset, 0); 107 DCHECK_GE(offset, 0);
108 DCHECK_LT(static_cast<size_t>(offset), kBufferSize); 108 DCHECK_LT(static_cast<size_t>(offset), kBufferSize);
109 return static_cast<int32>(offset); 109 return static_cast<int32>(offset);
110 } 110 }
111 111
112 // Overridden from CommandBufferEngine. 112 // Overridden from CommandBufferEngine.
113 virtual void set_token(int32 token) OVERRIDE { 113 virtual void set_token(int32 token) override {
114 token_ = token; 114 token_ = token;
115 } 115 }
116 116
117 int32 token() const { 117 int32 token() const {
118 return token_; 118 return token_;
119 } 119 }
120 120
121 // Overridden from CommandBufferEngine. 121 // Overridden from CommandBufferEngine.
122 virtual bool SetGetBuffer(int32 transfer_buffer_id) OVERRIDE { 122 virtual bool SetGetBuffer(int32 transfer_buffer_id) override {
123 NOTREACHED(); 123 NOTREACHED();
124 return false; 124 return false;
125 } 125 }
126 126
127 // Overridden from CommandBufferEngine. 127 // Overridden from CommandBufferEngine.
128 virtual bool SetGetOffset(int32 offset) OVERRIDE { 128 virtual bool SetGetOffset(int32 offset) override {
129 if (static_cast<size_t>(offset) < kBufferSize) { 129 if (static_cast<size_t>(offset) < kBufferSize) {
130 get_offset_ = offset; 130 get_offset_ = offset;
131 return true; 131 return true;
132 } 132 }
133 return false; 133 return false;
134 } 134 }
135 135
136 // Overridden from CommandBufferEngine. 136 // Overridden from CommandBufferEngine.
137 virtual int32 GetGetOffset() OVERRIDE { 137 virtual int32 GetGetOffset() override {
138 return get_offset_; 138 return get_offset_;
139 } 139 }
140 140
141 private: 141 private:
142 bool IsValidSharedMemoryId(int32 shm_id) { 142 bool IsValidSharedMemoryId(int32 shm_id) {
143 return shm_id == kValidShmId || shm_id == kStartValidShmId; 143 return shm_id == kValidShmId || shm_id == kStartValidShmId;
144 } 144 }
145 145
146 scoped_refptr<gpu::Buffer> buffer_; 146 scoped_refptr<gpu::Buffer> buffer_;
147 int32 token_; 147 int32 token_;
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 MockCommandBufferEngine::kValidShmId, kSomeOffsetInSharedMemory); 504 MockCommandBufferEngine::kValidShmId, kSomeOffsetInSharedMemory);
505 EXPECT_NE(error::kNoError, ExecuteCmd(cmd)); 505 EXPECT_NE(error::kNoError, ExecuteCmd(cmd));
506 506
507 // Check that it fails if the size is invalid 507 // Check that it fails if the size is invalid
508 cmd.Init(kBucketId, 0, sizeof(kData) + 1, 508 cmd.Init(kBucketId, 0, sizeof(kData) + 1,
509 MockCommandBufferEngine::kValidShmId, kSomeOffsetInSharedMemory); 509 MockCommandBufferEngine::kValidShmId, kSomeOffsetInSharedMemory);
510 EXPECT_NE(error::kNoError, ExecuteCmd(cmd)); 510 EXPECT_NE(error::kNoError, ExecuteCmd(cmd));
511 } 511 }
512 512
513 } // namespace gpu 513 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/command_buffer_service.h ('k') | gpu/command_buffer/service/error_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698