Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 614103004: replace 'virtual ... OVERRIDE' with '... override' (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
Reviewers:
pauljensen, dcheng, Mikhail
CC:
asvitkine+watch_chromium.org, chromium-reviews, dsinclair+watch_chromium.org, erikwright+watch_chromium.org, gavinp+memory_chromium.org, Ilya Sherman, jshin+watch_chromium.org, sadrul, tfarina, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace 'virtual ... OVERRIDE' with '... override' BUG=417463

Patch Set 1 : process base/ #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+698 lines, -804 lines) Patch
M base/android/trace_event_binding.cc View 1 chunk +2 lines, -2 lines 1 comment Download
M base/async_socket_io_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M base/bind_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/compiler_specific.h View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/stack_trace_posix.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M base/debug/trace_event.h View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_argument.h View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_impl.cc View 13 chunks +26 lines, -33 lines 0 comments Download
M base/debug/trace_event_memory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/trace_event_memory.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_synthetic_delay.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_synthetic_delay_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_system_stats_monitor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/trace_event_system_stats_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M base/deferred_sequenced_task_runner.h View 1 chunk +7 lines, -8 lines 0 comments Download
M base/environment.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M base/file_version_info_mac.h View 1 chunk +16 lines, -16 lines 0 comments Download
M base/file_version_info_win.h View 1 chunk +16 lines, -16 lines 0 comments Download
M base/files/file_path_unittest.cc View 1 chunk +2 lines, -6 lines 2 comments Download
M base/files/file_path_watcher_browsertest.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M base/files/file_path_watcher_fsevents.h View 2 chunks +5 lines, -5 lines 0 comments Download
M base/files/file_path_watcher_kqueue.h View 2 chunks +8 lines, -8 lines 0 comments Download
M base/files/file_path_watcher_linux.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M base/files/file_path_watcher_mac.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M base/files/file_path_watcher_stub.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M base/files/file_path_watcher_win.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M base/files/file_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_util_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/files/important_file_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/memory_mapped_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/rtl.cc View 1 chunk +3 lines, -4 lines 2 comments Download
M base/json/json_file_value_serializer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/json/json_parser.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M base/json/json_string_value_serializer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/json/json_value_converter.h View 12 chunks +15 lines, -21 lines 0 comments Download
M base/json/json_value_serializer_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M base/lazy_instance_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/libdispatch_task_runner.h View 1 chunk +7 lines, -8 lines 0 comments Download
M base/mac/libdispatch_task_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/discardable_memory_ashmem.h View 1 chunk +6 lines, -6 lines 0 comments Download
M base/memory/discardable_memory_emulated.h View 1 chunk +6 lines, -6 lines 0 comments Download
M base/memory/discardable_memory_mac.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M base/memory/discardable_memory_malloc.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/memory/discardable_memory_manager_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M base/memory/linked_ptr_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M base/memory/ref_counted_memory.h View 4 chunks +8 lines, -8 lines 0 comments Download
M base/memory/scoped_ptr_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M base/memory/scoped_vector_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/memory/singleton_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_loop.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/message_loop/message_loop_proxy_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M base/message_loop/message_loop_proxy_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop/message_loop_proxy_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M base/message_loop/message_pump_android.h View 1 chunk +4 lines, -4 lines 0 comments Download
M base/message_loop/message_pump_default.h View 1 chunk +4 lines, -4 lines 0 comments Download
M base/message_loop/message_pump_glib.h View 1 chunk +4 lines, -4 lines 0 comments Download
M base/message_loop/message_pump_glib_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop/message_pump_io_ios_unittest.cc View 6 chunks +8 lines, -12 lines 0 comments Download
M base/message_loop/message_pump_libevent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M base/message_loop/message_pump_libevent_unittest.cc View 7 chunks +10 lines, -14 lines 0 comments Download
M base/message_loop/message_pump_mac.h View 6 chunks +14 lines, -14 lines 0 comments Download
M base/message_loop/message_pump_perftest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M base/metrics/field_trial_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/metrics/histogram.h View 9 chunks +24 lines, -25 lines 0 comments Download
M base/metrics/histogram_delta_serialization.h View 1 chunk +6 lines, -6 lines 0 comments Download
M base/metrics/histogram_samples.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M base/metrics/histogram_snapshot_manager_unittest.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M base/metrics/sample_map.h View 2 chunks +13 lines, -13 lines 0 comments Download
M base/metrics/sample_vector.h View 2 chunks +13 lines, -14 lines 0 comments Download
M base/metrics/sparse_histogram.h View 2 chunks +15 lines, -16 lines 0 comments Download
M base/metrics/stats_counters.h View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/stats_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/observer_list_unittest.cc View 9 chunks +9 lines, -17 lines 0 comments Download
M base/posix/file_descriptor_shuffle.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/posix/file_descriptor_shuffle_unittest.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M base/power_monitor/power_monitor_device_source.h View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/default_pref_store.h View 1 chunk +5 lines, -5 lines 0 comments Download
M base/prefs/default_pref_store_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/prefs/json_pref_store.h View 2 chunks +17 lines, -19 lines 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M base/prefs/overlay_user_pref_store.h View 1 chunk +18 lines, -20 lines 0 comments Download
M base/prefs/pref_change_registrar.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/prefs/pref_change_registrar_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_member.h View 3 chunks +6 lines, -6 lines 0 comments Download
M base/prefs/pref_notifier_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/prefs/pref_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_store_observer_mock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/prefs/pref_value_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/prefs/testing_pref_store.h View 1 chunk +16 lines, -18 lines 0 comments Download
M base/prefs/value_map_pref_store.h View 1 chunk +10 lines, -12 lines 0 comments Download
M base/process/kill_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/memory_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M base/process/process_iterator.h View 1 chunk +1 line, -1 line 0 comments Download
M base/sequence_checker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/sync_socket.h View 2 chunks +6 lines, -6 lines 0 comments Download
M base/sync_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/condition_variable_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/condition_variable_win.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M base/synchronization/lock_unittest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M base/synchronization/waitable_event_posix.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M base/synchronization/waitable_event_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/waitable_event_watcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/synchronization/waitable_event_watcher_posix.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M base/task_runner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/expectations/parser_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/test/gtest_xml_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M base/test/null_task_runner.h View 1 chunk +5 lines, -5 lines 0 comments Download
M base/test/perf_test_suite.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/power_monitor_test_base.h View 2 chunks +4 lines, -4 lines 0 comments Download
M base/test/scoped_path_override.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/test/sequenced_worker_pool_owner.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/test/simple_test_clock.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/simple_test_tick_clock.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_simple_task_runner.h View 1 chunk +5 lines, -5 lines 0 comments Download
M base/test/test_suite.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/test/test_support_android.cc View 2 chunks +5 lines, -10 lines 0 comments Download
M base/threading/non_thread_safe_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M base/threading/platform_thread_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M base/threading/sequenced_worker_pool.h View 2 chunks +5 lines, -5 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 3 chunks +12 lines, -13 lines 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M base/threading/simple_thread.h View 3 chunks +4 lines, -3 lines 0 comments Download
M base/threading/simple_thread_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M base/threading/thread.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_checker_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M base/threading/thread_collision_warner.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_collision_warner_unittest.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M base/threading/thread_local_storage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_local_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/threading/thread_perftest.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M base/threading/thread_unittest.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M base/threading/watchdog.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/threading/watchdog_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M base/threading/worker_pool.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M base/threading/worker_pool_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_posix_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/time/default_clock.h View 1 chunk +1 line, -1 line 0 comments Download
M base/time/default_tick_clock.h View 1 chunk +1 line, -1 line 0 comments Download
M base/time/pr_time_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/time/time_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/timer/hi_res_timer_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M base/timer/mock_timer.h View 1 chunk +7 lines, -7 lines 0 comments Download
M base/tools_sanity_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/values.h View 6 chunks +20 lines, -21 lines 0 comments Download
M base/win/enum_variant.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/win/iunknown_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/win/registry_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/shortcut_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (3 generated)
Mostyn Bramley-Moore
@dcheng: here's my first attempt at scripting the 'virtual ... OVERRIDE' -> '... override' change ...
6 years, 2 months ago (2014-09-30 22:35:23 UTC) #2
Mostyn Bramley-Moore
https://codereview.chromium.org/614103004/diff/1/base/android/trace_event_binding.cc File base/android/trace_event_binding.cc (right): https://codereview.chromium.org/614103004/diff/1/base/android/trace_event_binding.cc#newcode60 base/android/trace_event_binding.cc:60: void OnTraceLogEnabled() override { incorrect indentation here https://codereview.chromium.org/614103004/diff/1/base/i18n/rtl.cc File ...
6 years, 2 months ago (2014-09-30 22:43:59 UTC) #3
dcheng
I'm curious about your script--however, I wouldn't worry too much about scripting this to remove ...
6 years, 2 months ago (2014-09-30 22:44:02 UTC) #4
dcheng
(If you're interested in helping out with any of the clang tooling, I'd be happy ...
6 years, 2 months ago (2014-09-30 22:47:09 UTC) #5
Mostyn Bramley-Moore
> I'm curious about your script--however, I wouldn't worry too much about > scripting this ...
6 years, 2 months ago (2014-09-30 23:15:49 UTC) #6
Mostyn Bramley-Moore
On 2014/09/30 23:15:49, Mostyn Bramley-Moore wrote: > > The main thing > > I've been ...
6 years, 2 months ago (2014-10-01 13:00:56 UTC) #7
Mostyn Bramley-Moore
> If we have another method to make this change, perhaps we could use this ...
6 years, 2 months ago (2014-10-01 13:16:17 UTC) #9
dcheng
On 2014/10/01 13:00:56, Mostyn Bramley-Moore wrote: > On 2014/09/30 23:15:49, Mostyn Bramley-Moore wrote: > > ...
6 years, 2 months ago (2014-10-01 16:29:51 UTC) #10
Mostyn Bramley-Moore
> > If we have another method to make this change, perhaps we could use ...
6 years, 2 months ago (2014-10-01 18:53:51 UTC) #11
Mikhail
On 2014/10/01 13:16:17, Mostyn Bramley-Moore wrote: > > If we have another method to make ...
6 years, 2 months ago (2014-10-02 10:12:01 UTC) #12
Mostyn Bramley-Moore
On 2014/10/02 10:12:01, Mikhail wrote: > On 2014/10/01 13:16:17, Mostyn Bramley-Moore wrote: > > > ...
6 years, 2 months ago (2014-10-02 12:18:32 UTC) #13
dcheng
On 2014/10/02 at 12:18:32, mostynb wrote: > On 2014/10/02 10:12:01, Mikhail wrote: > > On ...
6 years, 2 months ago (2014-10-02 18:56:13 UTC) #14
Mostyn Bramley-Moore
> While the cpp approach is pretty neat, I think it's best to just take ...
6 years, 2 months ago (2014-10-02 21:35:45 UTC) #15
dcheng
On 2014/10/02 at 21:35:45, mostynb wrote: > > While the cpp approach is pretty neat, ...
6 years, 2 months ago (2014-10-02 21:49:06 UTC) #16
Mostyn Bramley-Moore
> > git grep -w FINAL | sed -e "s/:.*//" | uniq | grep -v ...
6 years, 2 months ago (2014-10-02 22:34:36 UTC) #17
dcheng
On 2014/10/02 at 22:34:36, mostynb wrote: > > > git grep -w FINAL | sed ...
6 years, 2 months ago (2014-10-02 22:57:23 UTC) #18
Mostyn Bramley-Moore
> > OK- should I do "git cl format" in each CL, or will this ...
6 years, 2 months ago (2014-10-02 23:31:09 UTC) #19
dcheng
On 2014/10/02 23:31:09, Mostyn Bramley-Moore wrote: > > > OK- should I do "git cl ...
6 years, 2 months ago (2014-10-02 23:46:34 UTC) #20
dcheng
On 2014/10/02 23:46:34, dcheng wrote: > On 2014/10/02 23:31:09, Mostyn Bramley-Moore wrote: > > > ...
6 years, 2 months ago (2014-10-02 23:49:12 UTC) #21
pauljensen
After reading over the discussion I guess this is the direction people wanted to go. ...
6 years, 2 months ago (2014-10-05 02:59:36 UTC) #23
Mostyn Bramley-Moore
6 years, 2 months ago (2014-10-05 07:26:31 UTC) #24
https://codereview.chromium.org/614103004/diff/1/base/files/file_path_unittes...
File base/files/file_path_unittest.cc (right):

https://codereview.chromium.org/614103004/diff/1/base/files/file_path_unittes...
base/files/file_path_unittest.cc:53: void SetUp() override {
PlatformTest::SetUp(); }
On 2014/10/05 02:59:36, pauljensen wrote:
> Do we want to be reformatting like this?

No- after earlier discussion in this CL, we chose a different process.  Here's
the replacement CL for base/ :
https://codereview.chromium.org/611153004/

(I will close this CL to avoid further confusion.)

Powered by Google App Engine
This is Rietveld 408576698