Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: base/prefs/default_pref_store_unittest.cc

Issue 614103004: replace 'virtual ... OVERRIDE' with '... override' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: process base/ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/prefs/default_pref_store.h" 5 #include "base/prefs/default_pref_store.h"
6 #include "testing/gtest/include/gtest/gtest.h" 6 #include "testing/gtest/include/gtest/gtest.h"
7 7
8 using base::StringValue; 8 using base::StringValue;
9 using base::Value; 9 using base::Value;
10 10
11 namespace { 11 namespace {
12 12
13 class MockPrefStoreObserver : public PrefStore::Observer { 13 class MockPrefStoreObserver : public PrefStore::Observer {
14 public: 14 public:
15 explicit MockPrefStoreObserver(DefaultPrefStore* pref_store); 15 explicit MockPrefStoreObserver(DefaultPrefStore* pref_store);
16 virtual ~MockPrefStoreObserver(); 16 virtual ~MockPrefStoreObserver();
17 17
18 int change_count() { 18 int change_count() {
19 return change_count_; 19 return change_count_;
20 } 20 }
21 21
22 // PrefStore::Observer implementation: 22 // PrefStore::Observer implementation:
23 virtual void OnPrefValueChanged(const std::string& key) OVERRIDE; 23 void OnPrefValueChanged(const std::string& key) override;
24 virtual void OnInitializationCompleted(bool succeeded) OVERRIDE {} 24 void OnInitializationCompleted(bool succeeded) override {}
25 25
26 private: 26 private:
27 DefaultPrefStore* pref_store_; 27 DefaultPrefStore* pref_store_;
28 28
29 int change_count_; 29 int change_count_;
30 30
31 DISALLOW_COPY_AND_ASSIGN(MockPrefStoreObserver); 31 DISALLOW_COPY_AND_ASSIGN(MockPrefStoreObserver);
32 }; 32 };
33 33
34 MockPrefStoreObserver::MockPrefStoreObserver(DefaultPrefStore* pref_store) 34 MockPrefStoreObserver::MockPrefStoreObserver(DefaultPrefStore* pref_store)
(...skipping 25 matching lines...) Expand all
60 pref_store->ReplaceDefaultValue(kPrefKey, 60 pref_store->ReplaceDefaultValue(kPrefKey,
61 scoped_ptr<Value>(new StringValue("bar"))); 61 scoped_ptr<Value>(new StringValue("bar")));
62 EXPECT_EQ(1, observer.change_count()); 62 EXPECT_EQ(1, observer.change_count());
63 63
64 // But only if the value actually changed. 64 // But only if the value actually changed.
65 pref_store->ReplaceDefaultValue(kPrefKey, 65 pref_store->ReplaceDefaultValue(kPrefKey,
66 scoped_ptr<Value>(new StringValue("bar"))); 66 scoped_ptr<Value>(new StringValue("bar")));
67 EXPECT_EQ(1, observer.change_count()); 67 EXPECT_EQ(1, observer.change_count());
68 } 68 }
69 69
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698