replace OVERRIDE and FINAL with override and final in base/

replace OVERRIDE and FINAL with override and final in base/

BUG=417463
Committed: https://crrev.com/9e096de10e6fdcafde67df469ed9a6b8b156dfb1
Cr-Commit-Position: refs/heads/master@{#298520}

[Mostyn Bramley-Moore, 2014-10-03 11:26:35]

mostynb@opera.com changed reviewers:
+ brettw@chromium.org, dcheng@chromium.org

[Mostyn Bramley-Moore, 2014-10-03 11:27:59]

@brettw: can you give this a thumbs-up?

The script I used to make this change is mentioned in the comments over here:
https://codereview.chromium.org/614103004/

[brettw, 2014-10-03 16:36:11]

I just removed myself from base owners and added some new people. Maybe add one
of them?

[Mostyn Bramley-Moore, 2014-10-03 16:45:42]

mostynb@opera.com changed reviewers:
+ danakj@chromium.org

[Mostyn Bramley-Moore, 2014-10-03 16:46:55]

On 2014/10/03 16:36:11, brettw wrote:
> I just removed myself from base owners and added some new people. Maybe add
one
> of them?

+danakj: since you already looked an another one of these
(https://codereview.chromium.org/628443002/).  Would you like a similar
PRESUBMIT.py rule for base/ ?

[Mostyn Bramley-Moore, 2014-10-03 16:47:20]

mostynb@opera.com changed reviewers:
- brettw@chromium.org

[danakj, 2014-10-03 16:54:52]

On 2014/10/03 16:46:55, Mostyn Bramley-Moore wrote:
> On 2014/10/03 16:36:11, brettw wrote:
> > I just removed myself from base owners and added some new people. Maybe add
> one
> > of them?
> 
> +danakj: since you already looked an another one of these
> (https://codereview.chromium.org/628443002/).  Would you like a similar
> PRESUBMIT.py rule for base/ ?

That'd be great. Less work for us later if people use the old way.

[Mostyn Bramley-Moore, 2014-10-07 08:10:52]

On 2014/10/03 16:54:52, danakj wrote:
> On 2014/10/03 16:46:55, Mostyn Bramley-Moore wrote:
> > On 2014/10/03 16:36:11, brettw wrote:
> > > I just removed myself from base owners and added some new people. Maybe
add
> > one
> > > of them?
> > 
> > +danakj: since you already looked an another one of these
> > (https://codereview.chromium.org/628443002/).  Would you like a similar
> > PRESUBMIT.py rule for base/ ?
> 
> That'd be great. Less work for us later if people use the old way.

@danakj: added the temporary check, PTAL.

[danakj, 2014-10-07 14:33:23]

LGTM. BTW Will you be moving the presubmit up to src/ when this is done or will
clang be checking for this?

https://codereview.chromium.org/611153004/diff/20001/base/PRESUBMIT.py
File base/PRESUBMIT.py (right):

https://codereview.chromium.org/611153004/diff/20001/base/PRESUBMIT.py#newcode13
base/PRESUBMIT.py:13: CC_SOURCE_FILES=(r'^base/.*\.(cc|h|mm)$',)
BASE_?

[Mostyn Bramley-Moore, 2014-10-07 14:42:18]

> LGTM. BTW Will you be moving the presubmit up to src/ when
> this is done or will
> clang be checking for this?

I was hoping that we could just land this quickly after the last usage of
OVERRIDE and FINAL are removed:
https://codereview.chromium.org/631963005/

https://codereview.chromium.org/611153004/diff/20001/base/PRESUBMIT.py
File base/PRESUBMIT.py (right):

https://codereview.chromium.org/611153004/diff/20001/base/PRESUBMIT.py#newcode13
base/PRESUBMIT.py:13: CC_SOURCE_FILES=(r'^base/.*\.(cc|h|mm)$',)
On 2014/10/07 14:33:23, danakj wrote:
> BASE_?

Done.

[Mostyn Bramley-Moore, 2014-10-07 14:42:30]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2014-10-07 14:42:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/611153004/40001

[commit-bot: I haz the power, 2014-10-07 15:46:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-07 15:46:56]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mostyn Bramley-Moore, 2014-10-07 15:58:18]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2014-10-07 15:59:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/611153004/40001

[commit-bot: I haz the power, 2014-10-07 17:59:25]

Committed patchset #3 (id:40001) as 6290b39e449f3b54bb934d040fe4f9f8173ac0bc

[commit-bot: I haz the power, 2014-10-07 17:59:59]

Patchset 3 (id:??) landed as
https://crrev.com/9e096de10e6fdcafde67df469ed9a6b8b156dfb1
Cr-Commit-Position: refs/heads/master@{#298520}