Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: base/json/json_file_value_serializer.h

Issue 614103004: replace 'virtual ... OVERRIDE' with '... override' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: process base/ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_ 5 #ifndef BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_
6 #define BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_ 6 #define BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/base_export.h" 10 #include "base/base_export.h"
(...skipping 14 matching lines...) Expand all
25 virtual ~JSONFileValueSerializer() {} 25 virtual ~JSONFileValueSerializer() {}
26 26
27 // DO NOT USE except in unit tests to verify the file was written properly. 27 // DO NOT USE except in unit tests to verify the file was written properly.
28 // We should never serialize directly to a file since this will block the 28 // We should never serialize directly to a file since this will block the
29 // thread. Instead, serialize to a string and write to the file you want on 29 // thread. Instead, serialize to a string and write to the file you want on
30 // the file thread. 30 // the file thread.
31 // 31 //
32 // Attempt to serialize the data structure represented by Value into 32 // Attempt to serialize the data structure represented by Value into
33 // JSON. If the return value is true, the result will have been written 33 // JSON. If the return value is true, the result will have been written
34 // into the file whose name was passed into the constructor. 34 // into the file whose name was passed into the constructor.
35 virtual bool Serialize(const base::Value& root) OVERRIDE; 35 bool Serialize(const base::Value& root) override;
36 36
37 // Equivalent to Serialize(root) except binary values are omitted from the 37 // Equivalent to Serialize(root) except binary values are omitted from the
38 // output. 38 // output.
39 bool SerializeAndOmitBinaryValues(const base::Value& root); 39 bool SerializeAndOmitBinaryValues(const base::Value& root);
40 40
41 // Attempt to deserialize the data structure encoded in the file passed 41 // Attempt to deserialize the data structure encoded in the file passed
42 // in to the constructor into a structure of Value objects. If the return 42 // in to the constructor into a structure of Value objects. If the return
43 // value is NULL, and if |error_code| is non-null, |error_code| will 43 // value is NULL, and if |error_code| is non-null, |error_code| will
44 // contain an integer error code (either JsonFileError or JsonParseError). 44 // contain an integer error code (either JsonFileError or JsonParseError).
45 // If |error_message| is non-null, it will be filled in with a formatted 45 // If |error_message| is non-null, it will be filled in with a formatted
46 // error message including the location of the error if appropriate. 46 // error message including the location of the error if appropriate.
47 // The caller takes ownership of the returned value. 47 // The caller takes ownership of the returned value.
48 virtual base::Value* Deserialize(int* error_code, 48 base::Value* Deserialize(int* error_code,
49 std::string* error_message) OVERRIDE; 49 std::string* error_message) override;
50 50
51 // This enum is designed to safely overlap with JSONReader::JsonParseError. 51 // This enum is designed to safely overlap with JSONReader::JsonParseError.
52 enum JsonFileError { 52 enum JsonFileError {
53 JSON_NO_ERROR = 0, 53 JSON_NO_ERROR = 0,
54 JSON_ACCESS_DENIED = 1000, 54 JSON_ACCESS_DENIED = 1000,
55 JSON_CANNOT_READ_FILE, 55 JSON_CANNOT_READ_FILE,
56 JSON_FILE_LOCKED, 56 JSON_FILE_LOCKED,
57 JSON_NO_SUCH_FILE 57 JSON_NO_SUCH_FILE
58 }; 58 };
59 59
(...skipping 19 matching lines...) Expand all
79 79
80 // A wrapper for ReadFileToString which returns a non-zero JsonFileError if 80 // A wrapper for ReadFileToString which returns a non-zero JsonFileError if
81 // there were file errors. 81 // there were file errors.
82 int ReadFileToString(std::string* json_string); 82 int ReadFileToString(std::string* json_string);
83 83
84 DISALLOW_IMPLICIT_CONSTRUCTORS(JSONFileValueSerializer); 84 DISALLOW_IMPLICIT_CONSTRUCTORS(JSONFileValueSerializer);
85 }; 85 };
86 86
87 #endif // BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_ 87 #endif // BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_
88 88
OLDNEW
« base/i18n/rtl.cc ('K') | « base/i18n/rtl.cc ('k') | base/json/json_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698