Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: base/threading/thread_collision_warner.h

Issue 614103004: replace 'virtual ... OVERRIDE' with '... override' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: process base/ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_THREADING_THREAD_COLLISION_WARNER_H_ 5 #ifndef BASE_THREADING_THREAD_COLLISION_WARNER_H_
6 #define BASE_THREADING_THREAD_COLLISION_WARNER_H_ 6 #define BASE_THREADING_THREAD_COLLISION_WARNER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/atomicops.h" 10 #include "base/atomicops.h"
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 // AsserterBase is the interfaces and DCheckAsserter is the default asserter 132 // AsserterBase is the interfaces and DCheckAsserter is the default asserter
133 // used. During the unit tests is used another class that doesn't "DCHECK" 133 // used. During the unit tests is used another class that doesn't "DCHECK"
134 // in case of collision (check thread_collision_warner_unittests.cc) 134 // in case of collision (check thread_collision_warner_unittests.cc)
135 struct BASE_EXPORT AsserterBase { 135 struct BASE_EXPORT AsserterBase {
136 virtual ~AsserterBase() {} 136 virtual ~AsserterBase() {}
137 virtual void warn() = 0; 137 virtual void warn() = 0;
138 }; 138 };
139 139
140 struct BASE_EXPORT DCheckAsserter : public AsserterBase { 140 struct BASE_EXPORT DCheckAsserter : public AsserterBase {
141 virtual ~DCheckAsserter() {} 141 virtual ~DCheckAsserter() {}
142 virtual void warn() OVERRIDE; 142 void warn() override;
143 }; 143 };
144 144
145 class BASE_EXPORT ThreadCollisionWarner { 145 class BASE_EXPORT ThreadCollisionWarner {
146 public: 146 public:
147 // The parameter asserter is there only for test purpose 147 // The parameter asserter is there only for test purpose
148 explicit ThreadCollisionWarner(AsserterBase* asserter = new DCheckAsserter()) 148 explicit ThreadCollisionWarner(AsserterBase* asserter = new DCheckAsserter())
149 : valid_thread_id_(0), 149 : valid_thread_id_(0),
150 counter_(0), 150 counter_(0),
151 asserter_(asserter) {} 151 asserter_(asserter) {}
152 152
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 // Here only for class unit tests purpose, during the test I need to not 236 // Here only for class unit tests purpose, during the test I need to not
237 // DCHECK but notify the collision with something else. 237 // DCHECK but notify the collision with something else.
238 AsserterBase* asserter_; 238 AsserterBase* asserter_;
239 239
240 DISALLOW_COPY_AND_ASSIGN(ThreadCollisionWarner); 240 DISALLOW_COPY_AND_ASSIGN(ThreadCollisionWarner);
241 }; 241 };
242 242
243 } // namespace base 243 } // namespace base
244 244
245 #endif // BASE_THREADING_THREAD_COLLISION_WARNER_H_ 245 #endif // BASE_THREADING_THREAD_COLLISION_WARNER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698