Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Side by Side Diff: base/sync_socket.h

Issue 614103004: replace 'virtual ... OVERRIDE' with '... override' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: process base/ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_SYNC_SOCKET_H_ 5 #ifndef BASE_SYNC_SOCKET_H_
6 #define BASE_SYNC_SOCKET_H_ 6 #define BASE_SYNC_SOCKET_H_
7 7
8 // A socket abstraction used for sending and receiving plain 8 // A socket abstraction used for sending and receiving plain
9 // data. Because the receiving is blocking, they can be used to perform 9 // data. Because the receiving is blocking, they can be used to perform
10 // rudimentary cross-process synchronization with low latency. 10 // rudimentary cross-process synchronization with low latency.
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 // a blocking Receive or Send. 117 // a blocking Receive or Send.
118 bool Shutdown(); 118 bool Shutdown();
119 119
120 #if defined(OS_WIN) 120 #if defined(OS_WIN)
121 // Since the Linux and Mac implementations actually use a socket, shutting 121 // Since the Linux and Mac implementations actually use a socket, shutting
122 // them down from another thread is pretty simple - we can just call 122 // them down from another thread is pretty simple - we can just call
123 // shutdown(). However, the Windows implementation relies on named pipes 123 // shutdown(). However, the Windows implementation relies on named pipes
124 // and there isn't a way to cancel a blocking synchronous Read that is 124 // and there isn't a way to cancel a blocking synchronous Read that is
125 // supported on <Vista. So, for Windows only, we override these 125 // supported on <Vista. So, for Windows only, we override these
126 // SyncSocket methods in order to support shutting down the 'socket'. 126 // SyncSocket methods in order to support shutting down the 'socket'.
127 virtual bool Close() OVERRIDE; 127 bool Close() override;
128 virtual size_t Receive(void* buffer, size_t length) OVERRIDE; 128 size_t Receive(void* buffer, size_t length) override;
129 virtual size_t ReceiveWithTimeout(void* buffer, 129 size_t ReceiveWithTimeout(void* buffer,
130 size_t length, 130 size_t length,
131 TimeDelta timeout) OVERRIDE; 131 TimeDelta timeout) override;
132 #endif 132 #endif
133 133
134 // Send() is overridden to catch cases where the remote end is not responding 134 // Send() is overridden to catch cases where the remote end is not responding
135 // and we fill the local socket buffer. When the buffer is full, this 135 // and we fill the local socket buffer. When the buffer is full, this
136 // implementation of Send() will not block indefinitely as 136 // implementation of Send() will not block indefinitely as
137 // SyncSocket::Send will, but instead return 0, as no bytes could be sent. 137 // SyncSocket::Send will, but instead return 0, as no bytes could be sent.
138 // Note that the socket will not be closed in this case. 138 // Note that the socket will not be closed in this case.
139 virtual size_t Send(const void* buffer, size_t length) OVERRIDE; 139 size_t Send(const void* buffer, size_t length) override;
140 140
141 private: 141 private:
142 #if defined(OS_WIN) 142 #if defined(OS_WIN)
143 WaitableEvent shutdown_event_; 143 WaitableEvent shutdown_event_;
144 WaitableEvent file_operation_; 144 WaitableEvent file_operation_;
145 #endif 145 #endif
146 DISALLOW_COPY_AND_ASSIGN(CancelableSyncSocket); 146 DISALLOW_COPY_AND_ASSIGN(CancelableSyncSocket);
147 }; 147 };
148 148
149 #if defined(OS_WIN) && !defined(COMPONENT_BUILD) 149 #if defined(OS_WIN) && !defined(COMPONENT_BUILD)
150 // TODO(cpu): remove this once chrome is split in two dlls. 150 // TODO(cpu): remove this once chrome is split in two dlls.
151 __declspec(selectany) 151 __declspec(selectany)
152 const SyncSocket::Handle SyncSocket::kInvalidHandle = INVALID_HANDLE_VALUE; 152 const SyncSocket::Handle SyncSocket::kInvalidHandle = INVALID_HANDLE_VALUE;
153 #endif 153 #endif
154 154
155 } // namespace base 155 } // namespace base
156 156
157 #endif // BASE_SYNC_SOCKET_H_ 157 #endif // BASE_SYNC_SOCKET_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698