Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 621133002: replace OVERRIDE and FINAL with override and final in ash/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
CC:
chromium-reviews, sadrul, derat+watch_chromium.org, tdanderson+overview_chromium.org, dcheng, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace OVERRIDE and FINAL with override and final in ash/ BUG=417463 Committed: https://crrev.com/10d6b38a855066b1400d96d0600c6e2aec42cbf1 Cr-Commit-Position: refs/heads/master@{#298040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2280 lines, -2280 lines) Patch
M ash/accelerators/accelerator_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M ash/accelerators/accelerator_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/exit_warning_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/accelerators/focus_manager_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/accelerators/key_hold_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/magnifier_key_scroller.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/accelerators/magnifier_key_scroller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/nested_accelerator_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/spoken_feedback_toggler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/accelerometer/accelerometer_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash_touch_exploration_manager_chromeos.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/autoclick/autoclick_controller.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M ash/autoclick/autoclick_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/content_support/gpu_support_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/default_accessibility_delegate.h View 1 chunk +23 lines, -23 lines 0 comments Download
M ash/default_user_wallpaper_delegate.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ash/desktop_background/desktop_background_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/desktop_background/desktop_background_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/desktop_background/desktop_background_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/desktop_background/desktop_background_widget_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/desktop_background/desktop_background_widget_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/desktop_background/wallpaper_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/cursor_window_controller.cc View 1 chunk +15 lines, -15 lines 0 comments Download
M ash/display/display_change_observer_chromeos.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/display/display_configurator_animation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/display_configurator_animation.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/display/display_controller.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M ash/display/display_error_observer_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_error_observer_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M ash/display/event_transformation_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mirror_window_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mirror_window_controller.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/display/mirror_window_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/mouse_cursor_event_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/display/projecting_observer_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/resolution_notification_controller.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/display/resolution_notification_controller.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/display/resolution_notification_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/root_window_transformers.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M ash/display/root_window_transformers_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/display/screen_ash.h View 1 chunk +12 lines, -12 lines 0 comments Download
M ash/display/screen_ash.cc View 1 chunk +12 lines, -12 lines 0 comments Download
M ash/display/screen_position_controller.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/display/screen_position_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/shared_display_edge_indicator.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/shared_display_edge_indicator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.h View 2 chunks +13 lines, -13 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +15 lines, -15 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 10 chunks +21 lines, -21 lines 0 comments Download
M ash/drag_drop/drag_drop_interactive_uitest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_image_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/extended_desktop_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ash/first_run/desktop_cleaner.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/first_run/first_run_helper_impl.h View 1 chunk +14 lines, -14 lines 0 comments Download
M ash/first_run/first_run_helper_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ash/focus_cycler_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/frame/caption_buttons/frame_caption_button.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view.h View 2 chunks +11 lines, -11 lines 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/frame/caption_buttons/frame_size_button.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/frame/caption_buttons/frame_size_button_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M ash/frame/custom_frame_view_ash.h View 2 chunks +15 lines, -15 lines 0 comments Download
M ash/frame/custom_frame_view_ash.cc View 6 chunks +15 lines, -15 lines 0 comments Download
M ash/frame/custom_frame_view_ash_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ash/frame/default_header_painter.h View 3 chunks +9 lines, -9 lines 0 comments Download
M ash/gpu_support_stub.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/high_contrast/high_contrast_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/host/ash_remote_window_tree_host_win.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ash/host/ash_window_tree_host_ozone.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M ash/host/ash_window_tree_host_win.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.h View 1 chunk +19 lines, -19 lines 0 comments Download
M ash/host/ash_window_tree_host_x11_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/host/transformer_helper.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/ime/candidate_view.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/ime/candidate_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/ime/candidate_view_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/ime/candidate_window_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/ime/candidate_window_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/ime/infolist_window.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/ime/infolist_window.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/ime/input_method_menu_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/ime/mode_indicator_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/ime/mode_indicator_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/keyboard_overlay/keyboard_overlay_delegate.h View 2 chunks +10 lines, -10 lines 0 comments Download
M ash/keyboard_overlay/keyboard_overlay_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/keyboard_overlay/keyboard_overlay_view.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/keyboard_uma_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/magnification_controller.cc View 2 chunks +15 lines, -15 lines 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/magnifier/partial_magnification_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/popup_message.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/root_window_controller.cc View 1 chunk +15 lines, -15 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M ash/rotator/screen_rotation.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/screensaver/screensaver_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/screensaver/screensaver_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/app_list_button.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ash/shelf/app_list_shelf_item_delegate.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/shelf/background_animator.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/overflow_bubble.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/shelf/overflow_bubble_view.h View 2 chunks +6 lines, -6 lines 0 comments Download
M ash/shelf/overflow_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_alignment_menu.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/shelf/shelf_bezel_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_button.h View 2 chunks +16 lines, -16 lines 0 comments Download
M ash/shelf/shelf_button.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_item_delegate_manager.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 2 chunks +8 lines, -8 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M ash/shelf/shelf_model_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/shelf/shelf_navigator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_tooltip_manager.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_view.h View 5 chunks +30 lines, -30 lines 0 comments Download
M ash/shelf/shelf_view.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M ash/shelf/shelf_widget.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 5 chunks +17 lines, -17 lines 0 comments Download
M ash/shelf/shelf_window_watcher.h View 3 chunks +11 lines, -11 lines 0 comments Download
M ash/shelf/shelf_window_watcher_item_delegate.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/shelf/shelf_window_watcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/app_list.cc View 4 chunks +26 lines, -26 lines 0 comments Download
M ash/shell/bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell/content_client/shell_content_browser_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell/content_client/shell_main_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/shell/context_menu.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/shell/keyboard_controller_proxy_stub.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/shell/lock_view.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/shell/panel_window.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/shell/shelf_delegate_impl.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 chunk +24 lines, -24 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 3 chunks +32 lines, -32 lines 0 comments Download
M ash/shell/toplevel_window.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/shell/widgets.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/shell/window_type_launcher.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ash/shell/window_type_launcher.cc View 3 chunks +14 lines, -14 lines 0 comments Download
M ash/shell/window_watcher.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/shell/window_watcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell/window_watcher_shelf_item_delegate.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/shell_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M ash/snap_to_pixel_layout_manager.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/sticky_keys/sticky_keys_overlay.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/sticky_keys/sticky_keys_overlay.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/sticky_keys/sticky_keys_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/audio/tray_audio.h View 1 chunk +15 lines, -15 lines 0 comments Download
M ash/system/audio/volume_view.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/system/audio/volume_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/bluetooth/tray_bluetooth.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ash/system/bluetooth/tray_bluetooth.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/audio/audio_detailed_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/audio/tray_audio_chromeos.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/audio/tray_audio_delegate_chromeos.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ash/system/chromeos/bluetooth/bluetooth_notification_controller.h View 1 chunk +11 lines, -11 lines 0 comments Download
M ash/system/chromeos/bluetooth/bluetooth_notification_controller.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/system/chromeos/brightness/brightness_controller_chromeos.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/brightness/tray_brightness.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ash/system/chromeos/brightness/tray_brightness.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/system/chromeos/enterprise/tray_enterprise.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/keyboard_brightness_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/multi_user/user_switch_util.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/system/chromeos/multi_user/user_switch_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.h View 2 chunks +13 lines, -13 lines 0 comments Download
M ash/system/chromeos/network/network_state_notifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/network/network_state_notifier_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/network/tray_network.h View 1 chunk +12 lines, -12 lines 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M ash/system/chromeos/network/tray_network_state_observer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/system/chromeos/network/tray_sms.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/system/chromeos/network/tray_sms.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ash/system/chromeos/network/tray_vpn.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ash/system/chromeos/network/tray_vpn.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/power_event_observer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/system/chromeos/power/power_event_observer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/power/power_status.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/power_status_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/power/power_status_view.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ash/system/chromeos/power/power_status_view_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/power/tray_power.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/tray_power_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/power/video_activity_notifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/screen_security/screen_capture_tray_item.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/system/chromeos/screen_security/screen_share_tray_item.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item.h View 3 chunks +12 lines, -12 lines 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/session/last_window_closed_logout_reminder.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/logout_button_tray.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/system/chromeos/session/logout_confirmation_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/logout_confirmation_controller_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/session/logout_confirmation_dialog.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/system/chromeos/session/tray_session_length_limit.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/session/tray_session_length_limit_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/settings/tray_settings.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/system/chromeos/settings/tray_settings.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/supervised/tray_supervised_user.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/supervised/tray_supervised_user_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/system_clock_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/tray_caps_lock.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/system/chromeos/tray_caps_lock.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/tray_display.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/tray_display.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/tray_display_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_tracing.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/system/chromeos/tray_tracing.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/system/date/date_default_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/date_view.h View 3 chunks +9 lines, -9 lines 0 comments Download
M ash/system/date/tray_date.h View 1 chunk +12 lines, -12 lines 0 comments Download
M ash/system/ime/tray_ime.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ash/system/ime/tray_ime.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/locale/locale_notification_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/locale/locale_notification_controller.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/system/overview/overview_button_tray.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/system/status_area_widget.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/status_area_widget_delegate.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/system/tray/actionable_view.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ash/system/tray/default_system_tray_delegate.h View 1 chunk +66 lines, -66 lines 0 comments Download
M ash/system/tray/default_system_tray_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/tray/fixed_sized_image_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/fixed_sized_scroll_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/tray/hover_highlight_view.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ash/system/tray/media_security/multi_profile_media_tray_item.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/media_security/multi_profile_media_tray_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/special_popup_row.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray.h View 2 chunks +13 lines, -13 lines 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ash/system/tray/system_tray_unittest.cc View 5 chunks +20 lines, -20 lines 0 comments Download
M ash/system/tray/throbber_view.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/system/tray/tray_background_view.h View 3 chunks +16 lines, -16 lines 0 comments Download
M ash/system/tray/tray_background_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/tray/tray_bar_button_with_title.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_bar_button_with_title.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_bubble_wrapper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_details_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_details_view.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ash/system/tray/tray_details_view_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M ash/system/tray/tray_empty.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/system/tray/tray_empty.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_event_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_image_item.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/system/tray/tray_item_more.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/tray/tray_item_view.h View 2 chunks +7 lines, -7 lines 0 comments Download
M ash/system/tray/tray_notification_view.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/system/tray/tray_popup_header_button.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/system/tray/tray_popup_label_button_border.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray_accessibility.h View 2 chunks +9 lines, -9 lines 0 comments Download
M ash/system/tray_update.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/system/tray_update.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/system/user/accounts_detailed_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/user/button_from_view.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/system/user/rounded_image_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/user/tray_user.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ash/system/user/tray_user_separator.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/system/user/tray_user_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/user_card_view.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ash/system/user/user_view.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/system/user/user_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate.h View 2 chunks +11 lines, -11 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.h View 1 chunk +25 lines, -25 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/system/win/audio/tray_audio_delegate_win.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ash/test/ash_test_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/ash_test_helper_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/ash_test_views_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/child_modal_window.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/test/child_modal_window.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/test/shelf_view_test_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/test_activation_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/test_lock_state_controller_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/test_metro_viewer_process_host.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/test/test_overlay_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/test/test_screenshot_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/test/test_session_state_animator.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/test/test_session_state_animator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_session_state_delegate.h View 1 chunk +20 lines, -20 lines 0 comments Download
M ash/test/test_session_state_delegate.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/test/test_shelf_delegate.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ash/test/test_shelf_item_delegate.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 chunk +24 lines, -24 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M ash/test/test_suite.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/test_system_tray_delegate.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/test/test_user_wallpaper_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_volume_control_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/test/ui_controls_factory_ash.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_hud_debug.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ash/touch/touch_hud_debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_hud_projection.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/touch/touch_hud_projection.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ash/touch/touch_observer_hud.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ash/touch/touch_observer_hud_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/touch/touch_transformer_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/touch/touchscreen_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/virtual_keyboard_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/always_on_top_controller.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/app_list_controller.h View 1 chunk +13 lines, -13 lines 0 comments Download
M ash/wm/app_list_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_focus_rules.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/ash_native_cursor_manager.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/wm/ash_native_cursor_manager_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_native_cursor_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/boot_splash_screen_chromeos.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/cursor_manager_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/default_state.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/default_window_resizer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.h View 2 chunks +16 lines, -16 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/drag_window_resizer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/event_client_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/gestures/long_press_affordance_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/gestures/long_press_affordance_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/gestures/tray_gesture_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/immersive_fullscreen_controller.h View 1 chunk +13 lines, -13 lines 0 comments Download
M ash/wm/immersive_fullscreen_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/immersive_fullscreen_controller_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M ash/wm/lock_layout_manager.h View 1 chunk +13 lines, -13 lines 0 comments Download
M ash/wm/lock_layout_manager_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M ash/wm/lock_state_controller.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_window_state.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/maximize_mode/workspace_backdrop_delegate.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/wm/mru_window_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/overlay_event_filter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/overview/scoped_window_copy.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/overview/transparent_activate_window_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_grid.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/overview/window_grid.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_item.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/overview/window_selector_panels.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ash/wm/overview/window_selector_panels.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/overview/window_selector_window.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ash/wm/panels/attached_panel_window_targeter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/panels/panel_frame_view.h View 2 chunks +12 lines, -12 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.h View 2 chunks +14 lines, -14 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/panels/panel_window_event_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/panels/panel_window_resizer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/partial_screenshot_view.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/wm/partial_screenshot_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/partial_screenshot_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/power_button_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/resize_handle_window_targeter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/resize_shadow_and_cursor_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/resize_shadow_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/root_window_layout_manager.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/wm/screen_dimmer.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/screen_dimmer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/session_state_animator_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/wm/session_state_animator_impl.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M ash/wm/stacking_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/status_area_layout_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/system_background_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 5 chunks +18 lines, -18 lines 0 comments Download
M ash/wm/system_modal_container_event_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/video_detector.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/video_detector_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/virtual_keyboard_container_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_animations.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/wm/window_animations_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/window_cycle_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_cycle_list.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_cycle_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_manager_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/window_modality_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_positioner_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/window_state.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_state.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/wm/window_state_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 1 chunk +15 lines, -15 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Mostyn Bramley-Moore
@danakj: can you give this a thumbs-up? The script I used to make this change ...
6 years, 2 months ago (2014-10-03 11:31:50 UTC) #2
Mostyn Bramley-Moore
6 years, 2 months ago (2014-10-03 11:32:14 UTC) #3
danakj
I'd love to but I'm not an owner here. -danakj +oshima
6 years, 2 months ago (2014-10-03 13:44:12 UTC) #5
Daniel Erat
wrote a small program to verify that this lgtm. :-P (although i didn't see any ...
6 years, 2 months ago (2014-10-03 14:51:55 UTC) #7
Mostyn Bramley-Moore
On 2014/10/03 14:51:55, Daniel Erat wrote: > wrote a small program to verify that this ...
6 years, 2 months ago (2014-10-03 15:17:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621133002/1
6 years, 2 months ago (2014-10-03 15:17:51 UTC) #10
Daniel Erat
On 2014/10/03 15:17:11, Mostyn Bramley-Moore wrote: > On 2014/10/03 14:51:55, Daniel Erat wrote: > > ...
6 years, 2 months ago (2014-10-03 15:21:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 62d64cca1d238a9dfa1e50f5aa44c9f624fa9858
6 years, 2 months ago (2014-10-03 16:24:05 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 16:24:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10d6b38a855066b1400d96d0600c6e2aec42cbf1
Cr-Commit-Position: refs/heads/master@{#298040}

Powered by Google App Engine
This is Rietveld 408576698