Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Side by Side Diff: base/metrics/sparse_histogram.h

Issue 614103004: replace 'virtual ... OVERRIDE' with '... override' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: process base/ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_METRICS_SPARSE_HISTOGRAM_H_ 5 #ifndef BASE_METRICS_SPARSE_HISTOGRAM_H_
6 #define BASE_METRICS_SPARSE_HISTOGRAM_H_ 6 #define BASE_METRICS_SPARSE_HISTOGRAM_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
(...skipping 19 matching lines...) Expand all
30 30
31 class BASE_EXPORT_PRIVATE SparseHistogram : public HistogramBase { 31 class BASE_EXPORT_PRIVATE SparseHistogram : public HistogramBase {
32 public: 32 public:
33 // If there's one with same name, return the existing one. If not, create a 33 // If there's one with same name, return the existing one. If not, create a
34 // new one. 34 // new one.
35 static HistogramBase* FactoryGet(const std::string& name, int32 flags); 35 static HistogramBase* FactoryGet(const std::string& name, int32 flags);
36 36
37 virtual ~SparseHistogram(); 37 virtual ~SparseHistogram();
38 38
39 // HistogramBase implementation: 39 // HistogramBase implementation:
40 virtual HistogramType GetHistogramType() const OVERRIDE; 40 HistogramType GetHistogramType() const override;
41 virtual bool HasConstructionArguments( 41 bool HasConstructionArguments(Sample expected_minimum,
42 Sample expected_minimum, 42 Sample expected_maximum,
43 Sample expected_maximum, 43 size_t expected_bucket_count) const override;
44 size_t expected_bucket_count) const OVERRIDE; 44 void Add(Sample value) override;
45 virtual void Add(Sample value) OVERRIDE; 45 void AddSamples(const HistogramSamples& samples) override;
46 virtual void AddSamples(const HistogramSamples& samples) OVERRIDE; 46 bool AddSamplesFromPickle(PickleIterator* iter) override;
47 virtual bool AddSamplesFromPickle(PickleIterator* iter) OVERRIDE; 47 scoped_ptr<HistogramSamples> SnapshotSamples() const override;
48 virtual scoped_ptr<HistogramSamples> SnapshotSamples() const OVERRIDE; 48 void WriteHTMLGraph(std::string* output) const override;
49 virtual void WriteHTMLGraph(std::string* output) const OVERRIDE; 49 void WriteAscii(std::string* output) const override;
50 virtual void WriteAscii(std::string* output) const OVERRIDE;
51 50
52 protected: 51 protected:
53 // HistogramBase implementation: 52 // HistogramBase implementation:
54 virtual bool SerializeInfoImpl(Pickle* pickle) const OVERRIDE; 53 bool SerializeInfoImpl(Pickle* pickle) const override;
55 54
56 private: 55 private:
57 // Clients should always use FactoryGet to create SparseHistogram. 56 // Clients should always use FactoryGet to create SparseHistogram.
58 explicit SparseHistogram(const std::string& name); 57 explicit SparseHistogram(const std::string& name);
59 58
60 friend BASE_EXPORT_PRIVATE HistogramBase* DeserializeHistogramInfo( 59 friend BASE_EXPORT_PRIVATE HistogramBase* DeserializeHistogramInfo(
61 PickleIterator* iter); 60 PickleIterator* iter);
62 static HistogramBase* DeserializeInfoImpl(PickleIterator* iter); 61 static HistogramBase* DeserializeInfoImpl(PickleIterator* iter);
63 62
64 virtual void GetParameters(DictionaryValue* params) const OVERRIDE; 63 void GetParameters(DictionaryValue* params) const override;
65 virtual void GetCountAndBucketData(Count* count, 64 void GetCountAndBucketData(Count* count,
66 int64* sum, 65 int64* sum,
67 ListValue* buckets) const OVERRIDE; 66 ListValue* buckets) const override;
68 67
69 // Helpers for emitting Ascii graphic. Each method appends data to output. 68 // Helpers for emitting Ascii graphic. Each method appends data to output.
70 void WriteAsciiImpl(bool graph_it, 69 void WriteAsciiImpl(bool graph_it,
71 const std::string& newline, 70 const std::string& newline,
72 std::string* output) const; 71 std::string* output) const;
73 72
74 // Write a common header message describing this histogram. 73 // Write a common header message describing this histogram.
75 void WriteAsciiHeader(const Count total_count, 74 void WriteAsciiHeader(const Count total_count,
76 std::string* output) const; 75 std::string* output) const;
77 76
78 // For constuctor calling. 77 // For constuctor calling.
79 friend class SparseHistogramTest; 78 friend class SparseHistogramTest;
80 79
81 // Protects access to |samples_|. 80 // Protects access to |samples_|.
82 mutable base::Lock lock_; 81 mutable base::Lock lock_;
83 82
84 SampleMap samples_; 83 SampleMap samples_;
85 84
86 DISALLOW_COPY_AND_ASSIGN(SparseHistogram); 85 DISALLOW_COPY_AND_ASSIGN(SparseHistogram);
87 }; 86 };
88 87
89 } // namespace base 88 } // namespace base
90 89
91 #endif // BASE_METRICS_SPARSE_HISTOGRAM_H_ 90 #endif // BASE_METRICS_SPARSE_HISTOGRAM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698