Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: base/threading/simple_thread.h

Issue 614103004: replace 'virtual ... OVERRIDE' with '... override' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: process base/ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // WARNING: You should probably be using Thread (thread.h) instead. Thread is 5 // WARNING: You should probably be using Thread (thread.h) instead. Thread is
6 // Chrome's message-loop based Thread abstraction, and if you are a 6 // Chrome's message-loop based Thread abstraction, and if you are a
7 // thread running in the browser, there will likely be assumptions 7 // thread running in the browser, there will likely be assumptions
8 // that your thread will have an associated message loop. 8 // that your thread will have an associated message loop.
9 // 9 //
10 // This is a simple thread interface that backs to a native operating system 10 // This is a simple thread interface that backs to a native operating system
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 // Return the thread id, only valid after Start(). 95 // Return the thread id, only valid after Start().
96 PlatformThreadId tid() { return tid_; } 96 PlatformThreadId tid() { return tid_; }
97 97
98 // Return True if Start() has ever been called. 98 // Return True if Start() has ever been called.
99 bool HasBeenStarted(); 99 bool HasBeenStarted();
100 100
101 // Return True if Join() has evern been called. 101 // Return True if Join() has evern been called.
102 bool HasBeenJoined() { return joined_; } 102 bool HasBeenJoined() { return joined_; }
103 103
104 // Overridden from PlatformThread::Delegate: 104 // Overridden from PlatformThread::Delegate:
105 virtual void ThreadMain() OVERRIDE; 105 void ThreadMain() override;
106 106
107 // Only set priorities with a careful understanding of the consequences. 107 // Only set priorities with a careful understanding of the consequences.
108 // This is meant for very limited use cases. 108 // This is meant for very limited use cases.
109 void SetThreadPriority(ThreadPriority priority) { 109 void SetThreadPriority(ThreadPriority priority) {
110 PlatformThread::SetThreadPriority(thread_, priority); 110 PlatformThread::SetThreadPriority(thread_, priority);
111 } 111 }
112 112
113 private: 113 private:
114 const std::string name_prefix_; 114 const std::string name_prefix_;
115 std::string name_; 115 std::string name_;
(...skipping 13 matching lines...) Expand all
129 virtual void Run() = 0; 129 virtual void Run() = 0;
130 }; 130 };
131 131
132 DelegateSimpleThread(Delegate* delegate, 132 DelegateSimpleThread(Delegate* delegate,
133 const std::string& name_prefix); 133 const std::string& name_prefix);
134 DelegateSimpleThread(Delegate* delegate, 134 DelegateSimpleThread(Delegate* delegate,
135 const std::string& name_prefix, 135 const std::string& name_prefix,
136 const Options& options); 136 const Options& options);
137 137
138 virtual ~DelegateSimpleThread(); 138 virtual ~DelegateSimpleThread();
139 virtual void Run() OVERRIDE; 139 void Run() override;
140
140 private: 141 private:
141 Delegate* delegate_; 142 Delegate* delegate_;
142 }; 143 };
143 144
144 // DelegateSimpleThreadPool allows you to start up a fixed number of threads, 145 // DelegateSimpleThreadPool allows you to start up a fixed number of threads,
145 // and then add jobs which will be dispatched to the threads. This is 146 // and then add jobs which will be dispatched to the threads. This is
146 // convenient when you have a lot of small work that you want done 147 // convenient when you have a lot of small work that you want done
147 // multi-threaded, but don't want to spawn a thread for each small bit of work. 148 // multi-threaded, but don't want to spawn a thread for each small bit of work.
148 // 149 //
149 // You just call AddWork() to add a delegate to the list of work to be done. 150 // You just call AddWork() to add a delegate to the list of work to be done.
(...skipping 17 matching lines...) Expand all
167 void JoinAll(); 168 void JoinAll();
168 169
169 // It is safe to AddWork() any time, before or after Start(). 170 // It is safe to AddWork() any time, before or after Start().
170 // Delegate* should always be a valid pointer, NULL is reserved internally. 171 // Delegate* should always be a valid pointer, NULL is reserved internally.
171 void AddWork(Delegate* work, int repeat_count); 172 void AddWork(Delegate* work, int repeat_count);
172 void AddWork(Delegate* work) { 173 void AddWork(Delegate* work) {
173 AddWork(work, 1); 174 AddWork(work, 1);
174 } 175 }
175 176
176 // We implement the Delegate interface, for running our internal threads. 177 // We implement the Delegate interface, for running our internal threads.
177 virtual void Run() OVERRIDE; 178 void Run() override;
178 179
179 private: 180 private:
180 const std::string name_prefix_; 181 const std::string name_prefix_;
181 int num_threads_; 182 int num_threads_;
182 std::vector<DelegateSimpleThread*> threads_; 183 std::vector<DelegateSimpleThread*> threads_;
183 std::queue<Delegate*> delegates_; 184 std::queue<Delegate*> delegates_;
184 base::Lock lock_; // Locks delegates_ 185 base::Lock lock_; // Locks delegates_
185 WaitableEvent dry_; // Not signaled when there is no work to do. 186 WaitableEvent dry_; // Not signaled when there is no work to do.
186 }; 187 };
187 188
188 } // namespace base 189 } // namespace base
189 190
190 #endif // BASE_THREADING_SIMPLE_THREAD_H_ 191 #endif // BASE_THREADING_SIMPLE_THREAD_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698