base/android/trace_event_binding.cc - Issue 614103004: replace 'virtual ... OVERRIDE' with '... override'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/trace_event_binding.cc

Issue 614103004: replace 'virtual ... OVERRIDE' with '... override' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: process base/ Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/android/trace_event_binding.cc

diff --git a/base/android/trace_event_binding.cc b/base/android/trace_event_binding.cc

index e261411f08be2b5a12bcaabcbfe7f63d1ed11fb0..ebd6584efc248be7c4fd5eec17c46180b9fa0f31 100644

--- a/base/android/trace_event_binding.cc

+++ b/base/android/trace_event_binding.cc

@@ -57,11 +57,11 @@ class TraceEventDataConverter {

class TraceEnabledObserver : public debug::TraceLog::EnabledStateObserver {

public:

- virtual void OnTraceLogEnabled() OVERRIDE {

+ void OnTraceLogEnabled() override {

Mostyn Bramley-Moore 2014/09/30 22:43:58 incorrect indentation here

JNIEnv* env = base::android::AttachCurrentThread();

base::android::Java_TraceEvent_setEnabled(env, true);

}

- virtual void OnTraceLogDisabled() OVERRIDE {

+ void OnTraceLogDisabled() override {

JNIEnv* env = base::android::AttachCurrentThread();

base::android::Java_TraceEvent_setEnabled(env, false);

}

« no previous file with comments | « no previous file | base/async_socket_io_handler.h » ('j') | base/files/file_path_unittest.cc » ('J')