Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 623833003: replace OVERRIDE and FINAL with override and final in android_webview/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
Reviewers:
dcheng, Torne
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace OVERRIDE and FINAL with override and final in android_webview/ BUG=417463 Committed: https://crrev.com/d731a491c905999cd6b70286165a3dbd24299624 Cr-Commit-Position: refs/heads/master@{#298465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -370 lines) Patch
M android_webview/browser/aw_browser_context.h View 1 chunk +14 lines, -14 lines 0 comments Download
M android_webview/browser/aw_browser_main_parts.h View 1 chunk +4 lines, -4 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.h View 3 chunks +40 lines, -40 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M android_webview/browser/aw_dev_tools_manager_delegate.h View 1 chunk +6 lines, -6 lines 0 comments Download
M android_webview/browser/aw_dev_tools_manager_delegate.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M android_webview/browser/aw_download_manager_delegate.h View 1 chunk +4 lines, -4 lines 0 comments Download
M android_webview/browser/aw_form_database_service.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_gl_surface.h View 1 chunk +7 lines, -7 lines 0 comments Download
M android_webview/browser/aw_javascript_dialog_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M android_webview/browser/aw_login_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_pref_store.h View 1 chunk +15 lines, -15 lines 0 comments Download
M android_webview/browser/aw_quota_permission_context.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_request_interceptor.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_resource_context.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/aw_web_resource_response.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M android_webview/browser/browser_view_renderer.h View 1 chunk +10 lines, -10 lines 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/deferred_gpu_command_service.h View 2 chunks +6 lines, -6 lines 0 comments Download
M android_webview/browser/global_tile_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/hardware_renderer.h View 1 chunk +15 lines, -15 lines 0 comments Download
M android_webview/browser/icon_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/net/android_stream_reader_url_request_job.h View 1 chunk +8 lines, -8 lines 0 comments Download
M android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M android_webview/browser/net/aw_network_delegate.h View 1 chunk +17 lines, -17 lines 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/net/aw_url_request_job_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M android_webview/browser/parent_output_surface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/renderer_host/aw_render_view_host_ext.h View 1 chunk +4 lines, -4 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h View 2 chunks +6 lines, -6 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/browser/renderer_host/print_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/common/aw_content_client.h View 1 chunk +5 lines, -5 lines 0 comments Download
M android_webview/lib/aw_browser_dependency_factory_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.h View 1 chunk +11 lines, -11 lines 0 comments Download
M android_webview/native/android_protocol_handler.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M android_webview/native/aw_autofill_client.h View 2 chunks +13 lines, -13 lines 0 comments Download
M android_webview/native/aw_contents.h View 3 chunks +21 lines, -21 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.h View 2 chunks +5 lines, -5 lines 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.h View 1 chunk +10 lines, -10 lines 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/native/aw_dev_tools_server.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M android_webview/native/aw_http_auth_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_media_url_interceptor.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_pdf_exporter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_settings.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.h View 1 chunk +11 lines, -11 lines 0 comments Download
M android_webview/native/aw_web_contents_view_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_web_preferences_populater_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_web_resource_response_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M android_webview/native/external_video_surface_container_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M android_webview/native/input_stream_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/native/java_browser_view_renderer_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/permission/media_access_permission_request.h View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/native/permission/permission_request_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/permission/permission_request_handler_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M android_webview/native/permission/simple_permission_request.h View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.h View 2 chunks +11 lines, -11 lines 0 comments Download
M android_webview/renderer/aw_render_frame_ext.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/renderer/aw_render_process_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/renderer/aw_render_view_ext.h View 1 chunk +5 lines, -5 lines 0 comments Download
M android_webview/renderer/print_render_frame_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/renderer/print_web_view_helper.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@Torne: can you give this a thumbs-up? The script I used to make this change ...
6 years, 2 months ago (2014-10-03 11:33:25 UTC) #2
Torne
lgtm
6 years, 2 months ago (2014-10-07 12:06:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623833003/1
6 years, 2 months ago (2014-10-07 13:05:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 099265a29cbc0b072cd26525ea50653cdafd8585
6 years, 2 months ago (2014-10-07 13:36:18 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 13:37:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d731a491c905999cd6b70286165a3dbd24299624
Cr-Commit-Position: refs/heads/master@{#298465}

Powered by Google App Engine
This is Rietveld 408576698