Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser (Closed)

Created:
6 years, 3 months ago by MRV
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, vandebo (ex-Chrome), cbentzel+watch_chromium.org, tzik, Lei Zhang, browser-components-watch_chromium.org, nhiroki, gcasto+watchlist_chromium.org, tommycli, Greg Billock, markusheintz_, kinuko+fileapi, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member ordering in chrome/browser Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/14cb4ad4c4a9289944ae1f0ff6485d38b1278c83 Cr-Commit-Position: refs/heads/master@{#295303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -56 lines) Patch
M chrome/browser/content_settings/permission_context_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/history/expire_history_backend.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/history/expire_history_backend.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/history_service.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/io_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/jumplist_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/jumplist_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_file_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_file_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/dns_probe_runner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/dns_probe_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/net_error_tab_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/net_error_tab_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/predictor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_mobile.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_mobile.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
MRV
PTAL
6 years, 3 months ago (2014-09-17 06:04:15 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-17 14:40:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575993002/1
6 years, 3 months ago (2014-09-17 17:05:18 UTC) #5
MRV
On 2014/09/17 14:40:46, sky wrote: > LGTM Dear mr.sky.. thank you for LGTM
6 years, 3 months ago (2014-09-17 17:21:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6f016551ffb152f8cf38b7c151f3079b0884e30c
6 years, 3 months ago (2014-09-17 18:15:21 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 18:15:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14cb4ad4c4a9289944ae1f0ff6485d38b1278c83
Cr-Commit-Position: refs/heads/master@{#295303}

Powered by Google App Engine
This is Rietveld 408576698