Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2940)

Unified Diff: chrome/browser/history/history_service.h

Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/expire_history_backend.cc ('k') | chrome/browser/history/history_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_service.h
diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h
index b428b71cb83450ab82d1864927d22bb6ef909832..9be45da5db6fff2d78e2c9a16b7d90161f15bf64 100644
--- a/chrome/browser/history/history_service.h
+++ b/chrome/browser/history/history_service.h
@@ -827,9 +827,6 @@ class HistoryService : public content::NotificationObserver,
a, b, c, d, e));
}
- // All vended weak pointers are invalidated in Cleanup().
- base::WeakPtrFactory<HistoryService> weak_ptr_factory_;
-
base::ThreadChecker thread_checker_;
content::NotificationRegistrar registrar_;
@@ -883,6 +880,9 @@ class HistoryService : public content::NotificationObserver,
history::DeleteDirectiveHandler delete_directive_handler_;
+ // All vended weak pointers are invalidated in Cleanup().
+ base::WeakPtrFactory<HistoryService> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(HistoryService);
};
« no previous file with comments | « chrome/browser/history/expire_history_backend.cc ('k') | chrome/browser/history/history_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698