Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2914)

Unified Diff: chrome/browser/net/net_error_tab_helper.h

Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/dns_probe_runner.cc ('k') | chrome/browser/net/net_error_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/net_error_tab_helper.h
diff --git a/chrome/browser/net/net_error_tab_helper.h b/chrome/browser/net/net_error_tab_helper.h
index 195c8fa2b74541298b6d63db70d2e6814af7e49b..1104a96f184cd69a7b742ebf0bc22865468aca7f 100644
--- a/chrome/browser/net/net_error_tab_helper.h
+++ b/chrome/browser/net/net_error_tab_helper.h
@@ -87,8 +87,6 @@ class NetErrorTabHelper
void InitializePref(content::WebContents* contents);
bool ProbesAllowed() const;
- base::WeakPtrFactory<NetErrorTabHelper> weak_factory_;
-
// True if the last provisional load that started was for an error page.
bool is_error_page_;
@@ -112,6 +110,8 @@ class NetErrorTabHelper
// to allow probes.
BooleanPrefMember resolve_errors_with_web_service_;
+ base::WeakPtrFactory<NetErrorTabHelper> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(NetErrorTabHelper);
};
« no previous file with comments | « chrome/browser/net/dns_probe_runner.cc ('k') | chrome/browser/net/net_error_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698