chrome/browser/password_manager/chrome_password_manager_client.cc - Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.h ('k') | chrome/browser/policy/cloud/cloud_policy_invalidator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc

index 299e8af1f3a1f34085cdeed350f41931e21c25e5..4e10e36222734b65fa73689df8d319098249b543 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc

@@ -68,10 +68,10 @@ ChromePasswordManagerClient::ChromePasswordManagerClient(

profile_(Profile::FromBrowserContext(web_contents->GetBrowserContext())),

driver_(web_contents, this, autofill_client),

observer_(NULL),

- weak_factory_(this),

can_use_log_router_(false),

autofill_sync_state_(ALLOW_SYNC_CREDENTIALS),

- sync_credential_was_filtered_(false) {

+ sync_credential_was_filtered_(false),

+ weak_factory_(this) {

PasswordManagerInternalsService* service =

PasswordManagerInternalsServiceFactory::GetForBrowserContext(profile_);

if (service)