Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: chrome/browser/net/dns_probe_runner.h

Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media_galleries/fileapi/itunes_file_util.cc ('k') | chrome/browser/net/dns_probe_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/dns_probe_runner.h
diff --git a/chrome/browser/net/dns_probe_runner.h b/chrome/browser/net/dns_probe_runner.h
index 3f294c24f57dfef70fdc8f84569f537c1c0ec451..96c64befa71e66766dd3bce9590cc65a9e8fd916 100644
--- a/chrome/browser/net/dns_probe_runner.h
+++ b/chrome/browser/net/dns_probe_runner.h
@@ -63,8 +63,6 @@ class DnsProbeRunner {
const net::DnsResponse* response);
void CallCallback();
- base::WeakPtrFactory<DnsProbeRunner> weak_factory_;
-
scoped_ptr<net::DnsClient> client_;
// The callback passed to |RunProbe|. Cleared right before calling the
@@ -77,6 +75,8 @@ class DnsProbeRunner {
Result result_;
+ base::WeakPtrFactory<DnsProbeRunner> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(DnsProbeRunner);
};
« no previous file with comments | « chrome/browser/media_galleries/fileapi/itunes_file_util.cc ('k') | chrome/browser/net/dns_probe_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698