Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "components/password_manager/content/browser/content_password_manager_d river.h" 10 #include "components/password_manager/content/browser/content_password_manager_d river.h"
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 161
162 password_manager::ContentPasswordManagerDriver driver_; 162 password_manager::ContentPasswordManagerDriver driver_;
163 163
164 // Observer for password generation popup. 164 // Observer for password generation popup.
165 autofill::PasswordGenerationPopupObserver* observer_; 165 autofill::PasswordGenerationPopupObserver* observer_;
166 166
167 // Controls the popup 167 // Controls the popup
168 base::WeakPtr< 168 base::WeakPtr<
169 autofill::PasswordGenerationPopupControllerImpl> popup_controller_; 169 autofill::PasswordGenerationPopupControllerImpl> popup_controller_;
170 170
171 // Allows authentication callbacks to be destroyed when this client is gone.
172 base::WeakPtrFactory<ChromePasswordManagerClient> weak_factory_;
173
174 // True if |this| is registered with some LogRouter which can accept logs. 171 // True if |this| is registered with some LogRouter which can accept logs.
175 bool can_use_log_router_; 172 bool can_use_log_router_;
176 173
177 // How to handle the sync credential in ShouldFilterAutofillResult(). 174 // How to handle the sync credential in ShouldFilterAutofillResult().
178 AutofillForSyncCredentialsState autofill_sync_state_; 175 AutofillForSyncCredentialsState autofill_sync_state_;
179 176
180 // If the sync credential was filtered during autofill. Used for statistics 177 // If the sync credential was filtered during autofill. Used for statistics
181 // reporting. 178 // reporting.
182 bool sync_credential_was_filtered_; 179 bool sync_credential_was_filtered_;
183 180
181 // Allows authentication callbacks to be destroyed when this client is gone.
182 base::WeakPtrFactory<ChromePasswordManagerClient> weak_factory_;
183
184 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient); 184 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
185 }; 185 };
186 186
187 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 187 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
OLDNEW
« no previous file with comments | « chrome/browser/net/predictor.h ('k') | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698