Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Side by Side Diff: chrome/browser/policy/cloud/cloud_policy_invalidator.h

Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_POLICY_CLOUD_CLOUD_POLICY_INVALIDATOR_H_ 5 #ifndef CHROME_BROWSER_POLICY_CLOUD_CLOUD_POLICY_INVALIDATOR_H_
6 #define CHROME_BROWSER_POLICY_CLOUD_CLOUD_POLICY_INVALIDATOR_H_ 6 #define CHROME_BROWSER_POLICY_CLOUD_CLOUD_POLICY_INVALIDATOR_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 // invalidations do not provide a version number, this count is used to set 214 // invalidations do not provide a version number, this count is used to set
215 // invalidation_version_ when such invalidations occur. 215 // invalidation_version_ when such invalidations occur.
216 int unknown_version_invalidation_count_; 216 int unknown_version_invalidation_count_;
217 217
218 // The highest invalidation version that was handled already. 218 // The highest invalidation version that was handled already.
219 int64 highest_handled_invalidation_version_; 219 int64 highest_handled_invalidation_version_;
220 220
221 // The most up to date invalidation. 221 // The most up to date invalidation.
222 scoped_ptr<syncer::Invalidation> invalidation_; 222 scoped_ptr<syncer::Invalidation> invalidation_;
223 223
224 // WeakPtrFactory used to create callbacks to this object.
225 base::WeakPtrFactory<CloudPolicyInvalidator> weak_factory_;
226
227 // The maximum random delay, in ms, between receiving an invalidation and 224 // The maximum random delay, in ms, between receiving an invalidation and
228 // fetching the new policy. 225 // fetching the new policy.
229 int max_fetch_delay_; 226 int max_fetch_delay_;
230 227
231 // The hash value of the current policy. This is used to determine if a new 228 // The hash value of the current policy. This is used to determine if a new
232 // policy is different from the current one. 229 // policy is different from the current one.
233 uint32 policy_hash_value_; 230 uint32 policy_hash_value_;
234 231
235 // A thread checker to make sure that callbacks are invoked on the correct 232 // A thread checker to make sure that callbacks are invoked on the correct
236 // thread. 233 // thread.
237 base::ThreadChecker thread_checker_; 234 base::ThreadChecker thread_checker_;
238 235
236 // WeakPtrFactory used to create callbacks to this object.
237 base::WeakPtrFactory<CloudPolicyInvalidator> weak_factory_;
238
239 DISALLOW_COPY_AND_ASSIGN(CloudPolicyInvalidator); 239 DISALLOW_COPY_AND_ASSIGN(CloudPolicyInvalidator);
240 }; 240 };
241 241
242 } // namespace policy 242 } // namespace policy
243 243
244 #endif // CHROME_BROWSER_POLICY_CLOUD_CLOUD_POLICY_INVALIDATOR_H_ 244 #endif // CHROME_BROWSER_POLICY_CLOUD_CLOUD_POLICY_INVALIDATOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698