Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5481)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/predictor.h ('k') | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/chrome_password_manager_client.h
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h
index a93a68bc0140528e3050464613ea671e92757ab6..3f8d776852e5322242ccd0d7ae6107113a6b6213 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.h
+++ b/chrome/browser/password_manager/chrome_password_manager_client.h
@@ -168,9 +168,6 @@ class ChromePasswordManagerClient
base::WeakPtr<
autofill::PasswordGenerationPopupControllerImpl> popup_controller_;
- // Allows authentication callbacks to be destroyed when this client is gone.
- base::WeakPtrFactory<ChromePasswordManagerClient> weak_factory_;
-
// True if |this| is registered with some LogRouter which can accept logs.
bool can_use_log_router_;
@@ -181,6 +178,9 @@ class ChromePasswordManagerClient
// reporting.
bool sync_credential_was_filtered_;
+ // Allows authentication callbacks to be destroyed when this client is gone.
+ base::WeakPtrFactory<ChromePasswordManagerClient> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
};
« no previous file with comments | « chrome/browser/net/predictor.h ('k') | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698